From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nayna <nayna@linux.vnet.ibm.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de,
tpmdd@selhorst.net, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister)
Date: Thu, 24 Nov 2016 13:52:04 +0200 [thread overview]
Message-ID: <20161124115204.5hkqpuyh2cl64vje@intel.com> (raw)
In-Reply-To: <5835E103.90600@linux.vnet.ibm.com>
On Thu, Nov 24, 2016 at 12:03:39AM +0530, Nayna wrote:
>
>
> On 11/22/2016 10:12 PM, Jason Gunthorpe wrote:
> > On Tue, Nov 22, 2016 at 01:22:00PM +0200, Jarkko Sakkinen wrote:
> > > On Mon, Nov 14, 2016 at 05:00:51AM -0500, Nayna Jain wrote:
> > > > Check for TPM2 chip in tpm_sysfs_add_device, tpm_bios_log_setup and
> > > > tpm_bios_log_teardown in order to make code flow cleaner and to enable
> > > > to implement TPM 2.0 support later on. This is partially derived from
> > > > the commit by Nayna Jain with the extension that also tpm1_chip_register
> > > > is dropped.
> > > >
> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > >
> > > This commit remains unreviewed and tested. I'm in the author role here
> > > so I cannot help with this. If that does not happen soon I cannot put
> > > this into the pull request.
> >
> > I tested it on my ARM system when I tested your branch.
> >
> > I think it looks better this way..
> >
> > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> >
> > Jason
> >
>
> From my side also, as part of testing the whole patchset, I have tested this
> patch.
>
> Tested-by: Nayna Jain <nayna@linux.vnet.ibm.com>
> Reviewed-by: Nayna Jain <nayna@linux.vnet.ibm.com>
>
> Thanks & Regards,
> - Nayna
Thanks Nayna! I'll go on creating pull request...
/Jarkko
next prev parent reply other threads:[~2016-11-24 11:52 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 10:00 [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Nayna Jain
2016-11-14 10:00 ` [PATCH v6 1/9] tpm: define a generic open() method for ascii & bios measurements Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-14 10:00 ` [PATCH v6 2/9] tpm: replace symbolic permission with octal for securityfs files Nayna Jain
2016-11-14 22:18 ` Jarkko Sakkinen
2016-11-14 22:18 ` Jarkko Sakkinen
2016-11-14 22:21 ` Jarkko Sakkinen
2016-11-14 22:21 ` Jarkko Sakkinen
2016-11-15 0:11 ` [tpmdd-devel] " Jarkko Sakkinen
2016-11-15 0:11 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-22 11:23 ` Jarkko Sakkinen
2016-11-22 16:58 ` Jason Gunthorpe
2016-11-22 16:58 ` Jason Gunthorpe
2016-11-24 13:57 ` Jarkko Sakkinen
2016-11-24 13:57 ` Jarkko Sakkinen
2016-11-24 16:53 ` Jason Gunthorpe
2016-11-24 16:53 ` Jason Gunthorpe
2016-11-25 8:08 ` Jarkko Sakkinen
2016-11-25 8:08 ` Jarkko Sakkinen
2016-11-25 19:38 ` Jason Gunthorpe
2016-11-26 12:54 ` Jarkko Sakkinen
2016-11-22 19:26 ` Nayna
2016-11-24 14:01 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-22 11:22 ` Jarkko Sakkinen
2016-11-22 16:42 ` Jason Gunthorpe
2016-11-22 16:42 ` Jason Gunthorpe
2016-11-23 18:33 ` Nayna
2016-11-23 18:33 ` Nayna
2016-11-24 11:52 ` Jarkko Sakkinen [this message]
2016-11-24 11:51 ` Jarkko Sakkinen
2016-11-24 11:51 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 5/9] tpm: have event log use the tpm_chip Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-14 23:44 ` Jarkko Sakkinen
2016-11-15 0:12 ` Jarkko Sakkinen
2016-11-15 0:12 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 6/9] tpm: fix the missing .owner in tpm_bios_measurements_ops Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-14 22:22 ` Jarkko Sakkinen
2016-11-15 0:13 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 7/9] tpm: redefine read_log() to handle ACPI/OF at runtime Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-15 0:14 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 8/9] tpm: replace of_find_node_by_name() with dev of_node property Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-14 10:00 ` [PATCH v6 9/9] tpm: cleanup of printk error messages Nayna Jain
2016-11-14 10:00 ` Nayna Jain
2016-11-14 22:24 ` Jarkko Sakkinen
2016-11-14 22:24 ` Jarkko Sakkinen
2016-11-15 0:15 ` Jarkko Sakkinen
2016-11-14 22:33 ` [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen
2016-11-14 22:33 ` Jarkko Sakkinen
2016-11-15 0:25 ` Jarkko Sakkinen
2016-11-15 0:30 ` Jarkko Sakkinen
2016-11-15 0:30 ` Jarkko Sakkinen
2016-11-15 2:15 ` Jarkko Sakkinen
2016-11-15 5:35 ` Nayna
2016-11-15 5:35 ` Nayna
2016-11-15 17:40 ` Jarkko Sakkinen
2016-11-15 18:06 ` Jason Gunthorpe
2016-11-15 18:54 ` Jarkko Sakkinen
2016-11-19 18:36 ` Jason Gunthorpe
2016-11-19 18:36 ` Jason Gunthorpe
2016-11-20 9:58 ` Jarkko Sakkinen
2016-11-21 18:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124115204.5hkqpuyh2cl64vje@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.