All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
	Eric Blake <eblake@redhat.com>
Subject: [Qemu-devel] [PATCH v3 25/25] block/null: Generate filename even with latency-ns
Date: Wed, 30 Nov 2016 02:18:51 +0100	[thread overview]
Message-ID: <20161130011851.24696-26-mreitz@redhat.com> (raw)
In-Reply-To: <20161130011851.24696-1-mreitz@redhat.com>

While we cannot represent the latency-ns option in a filename, it is not
a significant option so not being able to should not stop us from
generating a filename nonetheless.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block/null.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/null.c b/block/null.c
index fb03fb9..f665bcf 100644
--- a/block/null.c
+++ b/block/null.c
@@ -231,7 +231,8 @@ static void null_refresh_filename(BlockDriverState *bs)
     {
         /* These options can be ignored */
         if (strcmp(qdict_entry_key(e), "filename") &&
-            strcmp(qdict_entry_key(e), "driver"))
+            strcmp(qdict_entry_key(e), "driver") &&
+            strcmp(qdict_entry_key(e), NULL_OPT_LATENCY))
         {
             return;
         }
-- 
2.10.2

      parent reply	other threads:[~2016-11-30  1:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30  1:18 [Qemu-devel] [PATCH v3 00/25] block: Fix some filename generation issues Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 01/25] block/mirror: Small absolute-paths simplification Max Reitz
2016-12-15 16:14   ` Alberto Garcia
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 02/25] block: Use children list in bdrv_refresh_filename Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 03/25] block: Add BDS.backing_overridden Max Reitz
2017-01-11 19:00   ` Eric Blake
2017-01-11 19:06     ` Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 04/25] block: Respect backing bs in bdrv_refresh_filename Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 05/25] block: Make path_combine() return the path Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 06/25] block: bdrv_get_full_backing_filename_from_...'s ret. val Max Reitz
2016-12-15 16:28   ` Alberto Garcia
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's " Max Reitz
2016-12-15 16:39   ` Alberto Garcia
2016-12-16 13:26     ` Max Reitz
2016-12-16 13:51       ` Alberto Garcia
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 08/25] block: Add bdrv_make_absolute_filename() Max Reitz
2016-12-16 10:23   ` Alberto Garcia
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 09/25] block: Fix bdrv_find_backing_image() Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 10/25] block: Add bdrv_dirname() Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 11/25] blkverify: Make bdrv_dirname() return NULL Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 12/25] quorum: " Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 13/25] block/nbd: Implement bdrv_dirname() Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 14/25] block/nfs: " Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 15/25] block: Use bdrv_dirname() for relative filenames Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 16/25] block: Add 'base-directory' BDS option Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 17/25] iotests: Add quorum case to test 110 Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 18/25] block: Add sgfnt_runtime_opts to BlockDriver Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 19/25] block: Add BlockDriver.bdrv_gather_child_options Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 20/25] block: Generically refresh runtime options Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 21/25] block: Purify .bdrv_refresh_filename() Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 22/25] block: Do not copy exact_filename from format file Max Reitz
2017-01-11 16:29   ` Max Reitz
2017-01-11 17:13     ` Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 23/25] block: Fix FIXME from "Add BDS.backing_overridden" Max Reitz
2016-11-30  1:18 ` [Qemu-devel] [PATCH v3 24/25] block/curl: Implement bdrv_refresh_filename() Max Reitz
2016-11-30  1:18 ` Max Reitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130011851.24696-26-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=berto@igalia.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.