From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Jason L Tibbitts III <tibbs@math.uh.edu>
Subject: Re: [PATCH] xfs: handle error if xfs_btree_get_bufs fails
Date: Wed, 14 Dec 2016 02:44:03 -0800 [thread overview]
Message-ID: <20161214104403.GA16862@infradead.org> (raw)
In-Reply-To: <f4473870-0514-87c3-6cf2-1dfd548a1e4a@sandeen.net>
On Mon, Dec 12, 2016 at 04:39:49PM -0600, Eric Sandeen wrote:
> Jason reported that a corrupted filesystem failed to replay
> the log with a metadata block out of bounds warning:
>
> XFS (dm-2): _xfs_buf_find: Block out of range: block 0x80270fff8, EOFS 0x9c40000
>
> _xfs_buf_find() and xfs_btree_get_bufs() return NULL if
> that happens, and then when xfs_alloc_fix_freelist() calls
> xfs_trans_binval() on that NULL bp, we oops with:
>
> BUG: unable to handle kernel NULL pointer dereference at 00000000000000f8
>
> We don't handle _xfs_buf_find errors very well, every
> caller higher up the stack gets to guess at why it failed.
> But we should at least handle it somehow, so return
> EFSCORRUPTED here.
>
> Reported-by: Jason L Tibbitts III <tibbs@math.uh.edu>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks fine, although the Subject line needs to lose to Re:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-12-14 11:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 22:00 [PATCH] xfs: handle error if xfs_btree_get_bufs fails Eric Sandeen
2016-12-12 22:14 ` Dave Chinner
2016-12-12 22:33 ` Eric Sandeen
2016-12-12 22:39 ` Eric Sandeen
2016-12-14 10:44 ` Christoph Hellwig [this message]
2017-10-10 2:19 ` Luis R. Rodriguez
2017-10-10 3:07 ` Eric Sandeen
2017-10-10 4:07 ` Darrick J. Wong
2017-10-13 0:02 ` Luis R. Rodriguez
2017-10-17 18:27 ` Luis R. Rodriguez
2017-10-17 18:35 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214104403.GA16862@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=tibbs@math.uh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.