From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, zhaoshenglong@huawei.com,
imammedo@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 00/11] Remove VirtGuestInfo
Date: Thu, 15 Dec 2016 18:38:30 +0200 [thread overview]
Message-ID: <20161215183759-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20161213214522.25548-1-drjones@redhat.com>
On Tue, Dec 13, 2016 at 10:45:11PM +0100, Andrew Jones wrote:
> This series is based on Peter's qemu-arm gicv3-virt branch. It's
> main goal (patches 04-10), which was suggested by Eduardo, is to
> remove an unnecessary structure, VirtGuestInfo, which is a
> maintenance burden, as it requires duplicating Virt machine state.
> Additionally patches 01-03 do some mach-virt cleanups and patch 11
> adds the ACPI equivalent to one of the DT patches in Peter's
> gicv3-virt branch.
>
> The last patch isn't really tested as the guest kernel versions I
> used seem to ignore the GTDT irqflags and either just choose edge,
> 4.5-based kernel, or level, 4.9-based kernel.
>
> Patches available here
> https://github.com/rhdrjones/qemu/commits/virt/remove-guest-info
I like this in general.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Pls merge through the ARM tree.
>
> Andrew Jones (11):
> hw/arm/virt: parameter passing cleanups
> hw/arm/virt: use VirtMachineState.gic_version
> hw/arm/virt: use VirtMachineState.smp_cpus
> hw/arm/virt: eliminate struct VirtGuestInfoState
> hw/arm/virt: remove include/hw/arm/virt-acpi-build.h
> hw/arm/virt: move VirtMachineState/Class to virt.h
> hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo
> hw/arm/virt-acpi-build: remove redundant members from VirtGuestInfo
> hw/arm/virt-acpi-build: don't save VirtGuestInfo on AcpiBuildState
> hw/arm/virt: remove VirtGuestInfo
> hw/arm/virt-acpi-build: Don't incorrectly claim architectural timer to
> be edge-triggered
>
> MAINTAINERS | 2 -
> hw/arm/virt-acpi-build.c | 103 +++++++++++++-------------
> hw/arm/virt.c | 152 ++++++++++++++-------------------------
> include/hw/arm/virt-acpi-build.h | 47 ------------
> include/hw/arm/virt.h | 45 +++++++++++-
> 5 files changed, 151 insertions(+), 198 deletions(-)
> delete mode 100644 include/hw/arm/virt-acpi-build.h
>
> --
> 2.9.3
prev parent reply other threads:[~2016-12-15 16:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 21:45 [Qemu-devel] [PATCH 00/11] Remove VirtGuestInfo Andrew Jones
2016-12-13 21:45 ` [Qemu-devel] [PATCH 01/11] hw/arm/virt: parameter passing cleanups Andrew Jones
2016-12-15 9:53 ` Igor Mammedov
2016-12-13 21:45 ` [Qemu-devel] [PATCH 02/11] hw/arm/virt: use VirtMachineState.gic_version Andrew Jones
2016-12-15 10:22 ` Igor Mammedov
2016-12-13 21:45 ` [Qemu-devel] [PATCH 03/11] hw/arm/virt: use VirtMachineState.smp_cpus Andrew Jones
2016-12-15 10:37 ` Igor Mammedov
2016-12-15 11:55 ` Andrew Jones
2016-12-13 21:45 ` [Qemu-devel] [PATCH 04/11] hw/arm/virt: eliminate struct VirtGuestInfoState Andrew Jones
2016-12-15 14:13 ` Igor Mammedov
2016-12-13 21:45 ` [Qemu-devel] [PATCH 05/11] hw/arm/virt: remove include/hw/arm/virt-acpi-build.h Andrew Jones
2016-12-15 14:26 ` Igor Mammedov
2016-12-13 21:45 ` [Qemu-devel] [PATCH 06/11] hw/arm/virt: move VirtMachineState/Class to virt.h Andrew Jones
2016-12-15 14:32 ` Igor Mammedov
2016-12-13 21:45 ` [Qemu-devel] [PATCH 07/11] hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo Andrew Jones
2016-12-15 14:45 ` Igor Mammedov
2016-12-15 16:24 ` Andrew Jones
2016-12-16 9:10 ` Igor Mammedov
2016-12-13 21:45 ` [Qemu-devel] [PATCH 08/11] hw/arm/virt-acpi-build: remove redundant members from VirtGuestInfo Andrew Jones
2016-12-15 15:04 ` Igor Mammedov
2016-12-13 21:45 ` [Qemu-devel] [PATCH 09/11] hw/arm/virt-acpi-build: don't save VirtGuestInfo on AcpiBuildState Andrew Jones
2016-12-15 15:08 ` Igor Mammedov
2016-12-15 16:25 ` Andrew Jones
2016-12-13 21:45 ` [Qemu-devel] [PATCH 10/11] hw/arm/virt: remove VirtGuestInfo Andrew Jones
2016-12-15 14:59 ` Igor Mammedov
2016-12-15 16:27 ` Andrew Jones
2016-12-13 21:45 ` [Qemu-devel] [PATCH 11/11] hw/arm/virt-acpi-build: Don't incorrectly claim architectural timer to be edge-triggered Andrew Jones
2016-12-15 16:38 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215183759-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.