Re: [PATCH 1/2] capability: export has_capability

From: "Serge E. Hallyn" <serge@hallyn.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Jike Song <jike.song@intel.com>,
	serge@hallyn.com, linux-security-module@vger.kernel.org,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kwankhede@nvidia.com, kraxel@redhat.com
Subject: Re: [PATCH 1/2] capability: export has_capability
Date: Thu, 12 Jan 2017 00:45:32 -0600	[thread overview]
Message-ID: <20170112064531.GA8577@mail.hallyn.com> (raw)
In-Reply-To: <20170111134701.7d153d34@t450s.home>

On Wed, Jan 11, 2017 at 01:47:01PM -0500, Alex Williamson wrote:
> On Thu, 22 Dec 2016 00:10:15 +0800
> Jike Song <jike.song@intel.com> wrote:
> 
> > has_capability() is sometimes needed by modules to test capability
> > for specified task other than current, so export it.
> > 
> > Cc: Alex Williamson <alex.williamson@redhat.com>
> > Cc: Kirti Wankhede <kwankhede@nvidia.com>
> > Signed-off-by: Jike Song <jike.song@intel.com>
> > ---
> >  kernel/capability.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/capability.c b/kernel/capability.c
> > index 4984e1f..e2e198c 100644
> > --- a/kernel/capability.c
> > +++ b/kernel/capability.c
> > @@ -318,6 +318,7 @@ bool has_capability(struct task_struct *t, int cap)
> >  {
> >  	return has_ns_capability(t, &init_user_ns, cap);
> >  }
> > +EXPORT_SYMBOL(has_capability);
> >  
> >  /**
> >   * has_ns_capability_noaudit - Does a task have a capability (unaudited)
> 
> Are we using EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL here to match the other
> exports in this file?  We could use _GPL to match the expected caller
> of this.
> 
> 
> Serge,
> 
> Do you have any comments on this patch?  I'd be happy to pull it
> through the vfio tree with an appropriate Ack.  Thanks,

Sure, thanks, looks good to me.

Acked-by: Serge Hallyn <serge@hallyn.com>