From: Daniel Vetter <daniel@ffwll.ch>
To: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Update drm_cache.c to pull in the new drm_cache.h
Date: Mon, 23 Jan 2017 09:39:59 +0100 [thread overview]
Message-ID: <20170123083959.64vfq3zzpjfr4pbx@phenom.ffwll.local> (raw)
In-Reply-To: <87r33wji1a.fsf@dilma.collabora.co.uk>
On Sat, Jan 21, 2017 at 06:05:05PM -0200, Gabriel Krisman Bertazi wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > The prototypes were moved to a new header, but the function definitions
> > were not updated to pull in the declarations.
> >
> > drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for ‘drm_clflush_pages’ [-Wmissing-prototypes]
> > drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for ‘drm_clflush_sg’ [-Wmissing-prototypes]
> > drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for ‘drm_clflush_virt_range’ [-Wmissing-prototypes]
> >
> > Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header file")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Patch is good, though I'm Embarrassed that I didn't have -Wmissing-prototypes
> enabled when testing this. Thanks Chris.
>
> Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Applied to drm-misc, thx.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-01-23 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 18:19 [PATCH] drm: Update drm_cache.c to pull in the new drm_cache.h Chris Wilson
2017-01-21 20:05 ` Gabriel Krisman Bertazi
2017-01-23 8:39 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123083959.64vfq3zzpjfr4pbx@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=alexander.deucher@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=krisman@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.