All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@collabora.com>
To: intel-gfx@lists.freedesktop.org,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Maarten Lankhorst <maarten.lankhorst@intel.com>,
	Gustavo Padovan <gustavo.padovan@collabora.com>,
	Daniel Stone <daniels@collabora.com>,
	Mika Kahola <mika.kahola@intel.com>,
	Petri Latvala <petri.latvala@intel.com>
Subject: [PATCH i-g-t v3 33/33] lib/igt_kms: Remove code obsoleted by dyn n_planes implementation
Date: Mon, 30 Jan 2017 09:12:24 -0500	[thread overview]
Message-ID: <20170130141224.25063-34-robert.foss@collabora.com> (raw)
In-Reply-To: <20170130141224.25063-1-robert.foss@collabora.com>

Due to the dyn n_planes implementation some attributes and functions
were made obsolete and cand be removed.

However to keep all of the tests building the obsolete code is
removed after all of the tests have been made compatible with the
dyn n_planes changes.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
---
 lib/igt_kms.c | 28 ----------------------------
 lib/igt_kms.h | 20 --------------------
 2 files changed, 48 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 961a3e4d..4ba6316d 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -346,32 +346,6 @@ int kmstest_pipe_to_index(char pipe)
 }
 
 /**
- * kmstest_plane_name:
- * @plane: display plane
- *
- * Returns: String representing @plane, e.g. "plane1".
- */
-const char *kmstest_plane_name(enum igt_plane plane)
-{
-	static const char *names[] = {
-		[IGT_PLANE_1] = "plane1",
-		[IGT_PLANE_2] = "plane2",
-		[IGT_PLANE_3] = "plane3",
-		[IGT_PLANE_4] = "plane4",
-		[IGT_PLANE_5] = "plane5",
-		[IGT_PLANE_6] = "plane6",
-		[IGT_PLANE_7] = "plane7",
-		[IGT_PLANE_8] = "plane8",
-		[IGT_PLANE_9] = "plane9",
-		[IGT_PLANE_CURSOR] = "cursor",
-	};
-
-	igt_assert(plane < ARRAY_SIZE(names) && names[plane]);
-
-	return names[plane];
-}
-
-/**
  * kmstest_plane_type_name:
  * @plane: display plane
  *
@@ -1671,7 +1645,6 @@ void igt_display_init(igt_display_t *display, int drm_fd)
 					plane = &pipe->planes[p];
 					plane->index = p++;
 				}
-				plane->is_primary = 1;
 				break;
 			case DRM_PLANE_TYPE_CURSOR:
 				if (pipe->plane_cursor == -1) {
@@ -1683,7 +1656,6 @@ void igt_display_init(igt_display_t *display, int drm_fd)
 					plane->index = p++;
 				}
 				display->has_cursor_plane = true;
-				plane->is_cursor = 1;
 				break;
 			default:
 				plane = &pipe->planes[p];
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 510657a3..25626187 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -58,24 +58,6 @@ enum pipe {
 };
 const char *kmstest_pipe_name(enum pipe pipe);
 int kmstest_pipe_to_index(char pipe);
-
-/* We namespace this enum to not conflict with the Android i915_drm.h */
-enum igt_plane {
-        IGT_PLANE_1 = 0,
-        IGT_PLANE_PRIMARY = IGT_PLANE_1,
-        IGT_PLANE_2,
-        IGT_PLANE_3,
-        IGT_PLANE_4,
-        IGT_PLANE_5,
-        IGT_PLANE_6,
-        IGT_PLANE_7,
-        IGT_PLANE_8,
-        IGT_PLANE_9,
-        IGT_PLANE_CURSOR, /* IGT_PLANE_CURSOR is always the last plane. */
-        IGT_MAX_PLANES,
-};
-
-const char *kmstest_plane_name(enum igt_plane plane);
 const char *kmstest_plane_type_name(int plane_type);
 
 enum port {
@@ -274,8 +256,6 @@ typedef struct {
 	int index;
 	/* capabilities */
 	int type;
-	unsigned int is_primary       : 1;
-	unsigned int is_cursor        : 1;
 	/* state tracking */
 	unsigned int fb_changed       : 1;
 	unsigned int position_changed : 1;
-- 
2.11.0.453.g787f75f05

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2017-01-30 14:13 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 14:11 [PATCH i-g-t v3 00/33] lib/igt_kms: Implement dynamic plane count support Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 01/33] lib/igt_kms: Add index property to kmstest_plane struct Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 02/33] lib/igt_kms: Avoid depencency on static plane count Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 03/33] lib/igt_kms: Rename kmstest properties nplanes and plane Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 04/33] lib/igt_kms: Implement dynamic plane count support Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 05/33] tests/kms_atomic_transition: Add support for dynamic number of planes Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 06/33] tests/kms_busy: " Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 07/33] tests/kms_chv_cursor_fail: " Robert Foss
2017-01-30 14:11 ` [PATCH i-g-t v3 08/33] tests/kms_crtc_background_color: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 09/33] tests/kms_cursor_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 10/33] tests/kms_cursor_legacy: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 11/33] tests/kms_fbc_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 12/33] tests/kms_fence_pin_leak: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 13/33] tests/kms_flip_event_leak: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 14/33] tests/kms_legacy_colorkey: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 15/33] tests/kms_mmap_write_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 16/33] tests/kms_mmio_vs_cs_flip: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 17/33] tests/kms_panel_fitting: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 18/33] tests/kms_pipe_color: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 19/33] tests/kms_plane: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 20/33] tests/kms_plane_multiple: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 21/33] tests/kms_plane_scaling: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 22/33] tests/kms_properties: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 23/33] tests/kms_psr_sink_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 24/33] tests/kms_pwrite_crc: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 25/33] tests/kms_rmfb: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 26/33] tests/kms_rotation_crc: " Robert Foss
2017-03-28 22:06   ` Jordan Justen
2017-03-28 22:19     ` Robert Foss
2017-03-28 23:08       ` Jordan Justen
2017-01-30 14:12 ` [PATCH i-g-t v3 27/33] tests/kms_sink_crc_basic: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 28/33] tests/kms_universal_plane: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 29/33] tests/kms_vblank: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 30/33] tests/prime_mmap_kms: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 31/33] tests/kms_ccs: " Robert Foss
2017-01-30 14:12 ` [PATCH i-g-t v3 32/33] tests/kms_plane_lowres: " Robert Foss
2017-01-30 14:12 ` Robert Foss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170130141224.25063-34-robert.foss@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=daniels@collabora.com \
    --cc=gustavo.padovan@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@intel.com \
    --cc=mika.kahola@intel.com \
    --cc=petri.latvala@intel.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.