Re: [PATCH RFC 3/6] COLO-Proxy: Setup userspace colo-proxy on secondary side

From: Wei Liu <wei.liu2@citrix.com>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	"eddie . dong" <eddie.dong@intel.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Yang Hongyang <imhy.yang@gmail.com>,
	Xen devel <xen-devel@lists.xenproject.org>,
	Bian Naimeng <biannm@cn.fujitsu.com>
Subject: Re: [PATCH RFC 3/6] COLO-Proxy: Setup userspace colo-proxy on secondary side
Date: Mon, 6 Feb 2017 11:25:22 +0000	[thread overview]
Message-ID: <20170206112522.cx7kofx45alenmgh@citrix.com> (raw)
In-Reply-To: <c290d097-5df7-49ba-d8b9-28334d2786ee@cn.fujitsu.com>

On Mon, Feb 06, 2017 at 05:27:43PM +0800, Zhang Chen wrote:
[...]
> 
> > 
> > >           set_disk_colo_restore(d_config);
> > >       } else {
> > >           unset_disk_colo_restore(d_config);
> > >       }
> > >       return do_domain_create(ctx, d_config, domid, restore_fd, send_back_fd,
> > > -                            params, colo_proxy_script, ao_how, aop_console_how);
> > > +                            params, colo_proxy_script, userspace_colo_proxy,
> > > +                            ao_how, aop_console_how);
> > >   }
> > >   int libxl_domain_soft_reset(libxl_ctx *ctx,
> > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> > > index 1bd2057..89c2c9d 100644
> > > --- a/tools/libxl/libxl_types.idl
> > > +++ b/tools/libxl/libxl_types.idl
> > > @@ -390,6 +390,7 @@ libxl_domain_restore_params = Struct("domain_restore_params", [
> > >       ("checkpointed_stream", integer),
> > >       ("stream_version", uint32, {'init_val': '1'}),
> > >       ("colo_proxy_script", string),
> > > +    ("userspace_colo_proxy", libxl_defbool),
> > I suppose you can use LIBXL_HAVE_COLO_USERSPACE_PROXY for this whole
> > series.
> 
> If I understand correctly, we use LIBXL_HAVE_COLO_USERSPACE_PROXY for
> this whole series means we make colo userspace proxy as default option,
> User can't use colo kernel proxy by a easy way (remus commands).
> The goal of this series is to provide a another way to run colo proxy(we
> recommended),
> We want to keep the colo kernel proxy function currently(maybe someone can
> maintain it), and when colo userspace proxy performance better than kernel
> proxy,
> we will change colo userspace as default option.
> 

No, that macro is not used to denote which mechanism is the default one.
It is used to indicate the availability of a particular thing in libxl.
So you can have that macro and choose whichever you want to be the
default.

Feel free to ask questions if I'm not clear enough.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel