All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: dri-devel@lists.freedesktop.org
Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Subject: [PATCH 01/14] drm: qxl: Drop device flags attribute
Date: Wed, 15 Feb 2017 19:39:54 -0200	[thread overview]
Message-ID: <20170215214007.10004-2-krisman@collabora.co.uk> (raw)
In-Reply-To: <20170215214007.10004-1-krisman@collabora.co.uk>

There are no device specific flags that we need to keep track of here.
Let it vanish.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
---
 drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
 drivers/gpu/drm/qxl/qxl_drv.h | 3 +--
 drivers/gpu/drm/qxl/qxl_kms.c | 5 +----
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index 8e17c241e63c..698e1a47def9 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.c
+++ b/drivers/gpu/drm/qxl/qxl_drv.c
@@ -79,7 +79,7 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (ret)
 		goto free_dev;
 
-	ret = qxl_device_init(qdev, &qxl_driver, pdev, ent->driver_data);
+	ret = qxl_device_init(qdev, &qxl_driver, pdev);
 	if (ret)
 		goto disable_pci;
 
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 785c17b56f73..647f0926cb50 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -243,7 +243,6 @@ struct qxl_device;
 
 struct qxl_device {
 	struct drm_device ddev;
-	unsigned long flags;
 
 	resource_size_t vram_base, vram_size;
 	resource_size_t surfaceram_base, surfaceram_size;
@@ -335,7 +334,7 @@ extern const struct drm_ioctl_desc qxl_ioctls[];
 extern int qxl_max_ioctl;
 
 int qxl_device_init(struct qxl_device *qdev, struct drm_driver *drv,
-		    struct pci_dev *pdev, unsigned long flags);
+		    struct pci_dev *pdev);
 void qxl_device_fini(struct qxl_device *qdev);
 
 int qxl_modeset_init(struct qxl_device *qdev);
diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
index 2dcd5c14cb56..2b1e1f3c825d 100644
--- a/drivers/gpu/drm/qxl/qxl_kms.c
+++ b/drivers/gpu/drm/qxl/qxl_kms.c
@@ -117,8 +117,7 @@ static void qxl_gc_work(struct work_struct *work)
 
 int qxl_device_init(struct qxl_device *qdev,
 		    struct drm_driver *drv,
-		    struct pci_dev *pdev,
-		    unsigned long flags)
+		    struct pci_dev *pdev)
 {
 	int r, sb;
 
@@ -130,8 +129,6 @@ int qxl_device_init(struct qxl_device *qdev,
 	pci_set_drvdata(pdev, &qdev->ddev);
 	qdev->ddev.dev_private = qdev;
 
-	qdev->flags = flags;
-
 	mutex_init(&qdev->gem.mutex);
 	mutex_init(&qdev->update_area_mutex);
 	mutex_init(&qdev->release_mutex);
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-02-15 21:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 21:39 [PATCH 00/14] qxl atomic modesetting Gabriel Krisman Bertazi
2017-02-15 21:39 ` Gabriel Krisman Bertazi [this message]
2017-02-17 19:46   ` [PATCH 01/14] drm: qxl: Drop device flags attribute Gustavo Padovan
2017-02-15 21:39 ` [PATCH 02/14] drm: qxl: Consolidate bo reservation when pinning Gabriel Krisman Bertazi
2017-02-17 19:58   ` Gustavo Padovan
2017-02-15 21:39 ` [PATCH 03/14] drm: qxl: Don't initialize vblank support Gabriel Krisman Bertazi
2017-02-15 21:39 ` [PATCH 04/14] drm: qxl: Expose creation of universal primary plane Gabriel Krisman Bertazi
2017-02-15 21:39 ` [PATCH 05/14] drm: qxl: Atomic phase 1: convert cursor to universal plane Gabriel Krisman Bertazi
2017-02-15 21:39 ` [PATCH 06/14] drm: qxl: Atomic phase 1: Use drm_plane_helpers for primary plane Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 07/14] drm: qxl: Atomic phase 1: Implement mode_set_nofb Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 08/14] drm: qxl: Atomic phase 1: Don't unpin primary when disabling crtc Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 09/14] drm: qxl: Atomic phase 2: Wire up state object handlers Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 10/14] drm: qxl: Atomic phase 2: Use drm_atomic_set_fb_for_plane helper Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 11/14] drm: qxl: Atomic phase 3: Use atomic handlers for planes Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 12/14] drm: qxl: Atomic phase 3: Wire up atomic set_config helper Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 13/14] drm: qxl: Atomic phase 3: Wire up atomic page_flip helper Gabriel Krisman Bertazi
2017-02-15 21:40 ` [PATCH 14/14] drm: qxl: Enable atomic modesetting ioctl Gabriel Krisman Bertazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215214007.10004-2-krisman@collabora.co.uk \
    --to=krisman@collabora.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.