From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v2 3/3] arm64: renesas: r8a7796: Enable SCIF DMA
Date: Thu, 2 Mar 2017 15:36:39 +0100 [thread overview]
Message-ID: <20170302143638.GS6301@verge.net.au> (raw)
In-Reply-To: <CAMuHMdUGbb4CjpGzXapprrcuKAfKw3wkYc77JOn1EKNRsMm3VA@mail.gmail.com>
On Tue, Feb 21, 2017 at 03:27:25PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Wed, Dec 7, 2016 at 5:44 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> > ---
> > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > index c5f0df5..782063a 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -430,6 +430,9 @@
> > <&cpg CPG_CORE R8A7796_CLK_S3D1>,
> > <&scif_clk>;
> > clock-names = "fck", "brg_int", "scif_clk";
> > + dmas = <&dmac1 0x51>, <&dmac1 0x50>,
> > + <&dmac2 0x51>, <&dmac2 0x50>;
> > + dma-names = "tx", "rx", "tx", "rx";
> > power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > status = "disabled";
>
> Apparently the DMA properties were added to the HSCIF nodes instead
> of the SCIF nodes while applying this patch?
>
> 3 lines of context is not sufficient to distinguish between the various SCIF
> and HSCIF nodes :-(
Thanks, I have updated renesas-devel accordingly.
I notice in renesas-devel there seems to be one "tx", "rx" DMA per SCIF
rather than two added in Ulrich's patch. Is there a reason for that?
next prev parent reply other threads:[~2017-03-02 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 16:44 [PATCH v2 0/3] r8a7796 SCIF integration Ulrich Hecht
2016-12-07 16:44 ` [PATCH v2 1/3] clk: renesas: r8a7796: Add SCIF clocks Ulrich Hecht
2016-12-09 9:12 ` Geert Uytterhoeven
2016-12-07 16:44 ` [PATCH v2 2/3] arm64: renesas: r8a7796: Add all SCIF nodes Ulrich Hecht
2016-12-08 9:06 ` Sergei Shtylyov
2016-12-07 16:44 ` [PATCH v2 3/3] arm64: renesas: r8a7796: Enable SCIF DMA Ulrich Hecht
2016-12-09 9:38 ` Geert Uytterhoeven
2017-02-21 14:27 ` Geert Uytterhoeven
2017-03-02 14:36 ` Simon Horman [this message]
2017-03-03 9:54 ` Geert Uytterhoeven
2017-03-06 8:44 ` Simon Horman
2016-12-08 13:34 ` [PATCH v2 0/3] r8a7796 SCIF integration Simon Horman
2016-12-09 9:42 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302143638.GS6301@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.