From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Dibyendu Majumdar <mobile@majumdar.org.uk>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: Sparse-LLVM issue compiling NULL pointers
Date: Fri, 3 Mar 2017 06:35:57 +0100 [thread overview]
Message-ID: <20170303053556.dvdbrx4pkm6jdilk@macpro.local> (raw)
In-Reply-To: <CACXZuxf8-L6hy+TOd6pfmiAhoOXc-K5YJwUjonmmOGxv_djVnA@mail.gmail.com>
On Thu, Mar 02, 2017 at 06:41:35PM +0000, Dibyendu Majumdar wrote:
> This seems spot on as by making change as below, the final assertion
> failure went away. I have not yet checked the generated code but that
> is next.
>
> case OP_ADD:
> if (symbol_is_fp_type(C, insn->type))
> target = LLVMBuildFAdd(fn->builder, lhs, rhs, target_name);
> else {
> if (LLVMGetTypeKind(LLVMTypeOf(lhs)) == LLVMPointerTypeKind) {
> target = LLVMBuildGEP(fn->builder, lhs, &rhs, 1, "");
> }
> else if (LLVMGetTypeKind(LLVMTypeOf(lhs)) == LLVMPointerTypeKind) {
Yes, this is what I meant but here you're testing twice the type of 'lhs'.
One of the test should be on 'rhs'.
Can you resend it in another thread once it's fixed?
Thanks,
Luc
next prev parent reply other threads:[~2017-03-03 5:46 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 6:20 Sparse-LLVM issue compiling NULL pointers Dibyendu Majumdar
2017-02-28 15:09 ` Luc Van Oostenryck
2017-02-28 16:04 ` Dibyendu Majumdar
2017-02-28 16:47 ` Luc Van Oostenryck
2017-02-28 16:49 ` Dibyendu Majumdar
2017-03-02 6:48 ` Luc Van Oostenryck
2017-02-28 17:03 ` Luc Van Oostenryck
2017-02-28 17:35 ` Luc Van Oostenryck
2017-02-28 17:42 ` Dibyendu Majumdar
2017-02-28 18:08 ` Dibyendu Majumdar
2017-03-01 5:49 ` Luc Van Oostenryck
2017-03-02 7:02 ` [PATCH] llvm: fix getting type of values Luc Van Oostenryck
2017-03-01 10:58 ` Sparse-LLVM issue compiling NULL pointers Dibyendu Majumdar
2017-03-01 14:45 ` Dibyendu Majumdar
2017-03-02 5:21 ` Luc Van Oostenryck
2017-03-02 5:41 ` Dibyendu Majumdar
2017-03-02 13:56 ` Luc Van Oostenryck
2017-03-02 14:05 ` Dibyendu Majumdar
2017-03-02 16:10 ` Luc Van Oostenryck
2017-03-02 14:33 ` Dibyendu Majumdar
2017-03-02 16:04 ` Luc Van Oostenryck
2017-03-02 16:29 ` Dibyendu Majumdar
2017-03-02 16:30 ` Dibyendu Majumdar
2017-03-02 17:18 ` Luc Van Oostenryck
2017-03-02 17:36 ` Dibyendu Majumdar
2017-03-02 20:09 ` Luc Van Oostenryck
2017-03-03 2:52 ` Dibyendu Majumdar
2017-03-03 3:01 ` Dibyendu Majumdar
2017-03-03 4:03 ` Dibyendu Majumdar
2017-03-03 5:24 ` [PATCH] llvm: fix output_op_[ptr]cast() Luc Van Oostenryck
2017-03-03 7:37 ` Dibyendu Majumdar
2017-03-03 18:06 ` Dibyendu Majumdar
2017-03-03 18:30 ` Dibyendu Majumdar
2017-03-03 19:55 ` Luc Van Oostenryck
2017-03-06 1:56 ` Christopher Li
2017-03-03 19:50 ` Luc Van Oostenryck
2017-03-03 19:54 ` Dibyendu Majumdar
2017-03-03 20:52 ` [PATCH] llvm: fix: do not mix pointers and floats when doing compares Luc Van Oostenryck
2017-03-03 4:16 ` Sparse-LLVM issue compiling NULL pointers Luc Van Oostenryck
2017-03-03 4:27 ` Luc Van Oostenryck
2017-03-03 4:38 ` Dibyendu Majumdar
2017-03-03 7:50 ` Luc Van Oostenryck
2017-03-03 12:39 ` Dibyendu Majumdar
2017-03-02 17:03 ` Dibyendu Majumdar
2017-03-02 17:18 ` Dibyendu Majumdar
2017-03-02 17:43 ` Luc Van Oostenryck
2017-03-02 18:58 ` Dibyendu Majumdar
2017-03-02 19:34 ` Luc Van Oostenryck
2017-03-02 17:50 ` Luc Van Oostenryck
2017-03-02 17:57 ` Luc Van Oostenryck
2017-03-02 18:02 ` Dibyendu Majumdar
2017-03-03 4:21 ` Luc Van Oostenryck
2017-03-02 17:27 ` Luc Van Oostenryck
2017-03-02 18:41 ` Dibyendu Majumdar
2017-03-03 5:35 ` Luc Van Oostenryck [this message]
2017-03-02 16:39 ` Dibyendu Majumdar
2017-03-02 17:21 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303053556.dvdbrx4pkm6jdilk@macpro.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=mobile@majumdar.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.