Re: [PATCH 10/10] drm/i915: Support variable cursor height on ivb+

From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 10/10] drm/i915: Support variable cursor height on ivb+
Date: Wed, 8 Mar 2017 11:45:27 +0100	[thread overview]
Message-ID: <20170308104527.2khbamwqdd4dij2f@phenom.ffwll.local> (raw)
In-Reply-To: <20170307223214.GC25491@nuc-i3427.alporthouse.com>

On Tue, Mar 07, 2017 at 10:32:14PM +0000, Chris Wilson wrote:
> On Tue, Mar 07, 2017 at 05:27:09PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > IVB introduced the CUR_FBC_CTL register which allows reducing the cursor
> > height down to 8 lines from the otherwise square cursor dimensions.
> > Implement support for it. CUR_FBC_CTL can't be used when the cursor
> > is rotated.
> > 
> > Commandeer the otherwise unused cursor->cursor.size to track the
> > current value of CUR_FBC_CTL to optimize away redundant CUR_FBC_CTL
> > writes, and to notice when we need to arm the update via CURBASE if
> > just CUR_FBC_CTL changes.
> 
> For userspace to discover this, they should just use trial and error
> during startup (using the legacy SetCursor)? Though the easiest way
> would cause the cursor to flicker - just hope the cursor is
> off/invisible on startup.
> 
> Code makes a lot of sense after all the refactoring, but I'll leave the
> register checking to somebody else unless they are lazier than I am.

TEST_ONLY atomic commits on the cursor plane. That's pretty much how it's
meant to be used (although no one yet figured out how to tell generic
userspace about fancy constraints like this one here).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx