From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] misc: use system FICLONE/FICLONERANGE/FIDEDUPERANGE definitions
Date: Wed, 8 Mar 2017 11:09:20 -0800 [thread overview]
Message-ID: <20170308190920.GQ5280@birch.djwong.org> (raw)
In-Reply-To: <20170308155313.GC4353@infradead.org>
On Wed, Mar 08, 2017 at 07:53:13AM -0800, Christoph Hellwig wrote:
> xfs_fs.h should never removed previously define APIs - that'll just
> break application.
Yeah, I should've erased those defines before they ended up in 4.9.
Oh well.
> So to be honest I'm not sure there is any upside to this patch - it
> adds tons of lines, does not add any functionality and breaks existing
> apps.
But is it a good idea to expose the reflink and dedupe xfs_io commands
on platforms where we know it isn't going to work? AFAIK those ioctls
are still Linux-only.
Or: how popular are the darwin and *bsd ports of xfsprogs? It looks
like OSX can only read XFS via fuse, and freebsd dropped XFS from
their kernel in 10.0.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-08 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 0:30 [PATCH 0/3] xfsprogs: 4.11 rollup Darrick J. Wong
2017-03-08 0:30 ` [PATCH 1/3] misc: use system FICLONE/FICLONERANGE/FIDEDUPERANGE definitions Darrick J. Wong
2017-03-08 15:53 ` Christoph Hellwig
2017-03-08 19:09 ` Darrick J. Wong [this message]
2017-03-08 0:30 ` [PATCH 2/3] xfs_repair: detect invalid zero-sized symlink inodes Darrick J. Wong
2017-03-08 0:30 ` [PATCH 3/3] xfs_io: support shutdown command on foreign fses Darrick J. Wong
2017-03-08 15:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308190920.GQ5280@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.