From: Liu Bo <bo.li.liu@oracle.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 6/7] btrfs: remove redundant parameter from reada_start_machine_dev
Date: Mon, 20 Mar 2017 14:04:20 -0700 [thread overview]
Message-ID: <20170320210420.GI5540@lim.localdomain> (raw)
In-Reply-To: <f8008e872818951e0f38474c6871e9e7e8a671ac.1489593696.git.dsterba@suse.com>
On Wed, Mar 15, 2017 at 05:02:39PM +0100, David Sterba wrote:
> We can read fs_info from dev.
>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Thanks,
-liubo
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
> fs/btrfs/reada.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c
> index c1fc79cd4b2a..91df381a60ce 100644
> --- a/fs/btrfs/reada.c
> +++ b/fs/btrfs/reada.c
> @@ -649,9 +649,9 @@ static int reada_pick_zone(struct btrfs_device *dev)
> return 1;
> }
>
> -static int reada_start_machine_dev(struct btrfs_fs_info *fs_info,
> - struct btrfs_device *dev)
> +static int reada_start_machine_dev(struct btrfs_device *dev)
> {
> + struct btrfs_fs_info *fs_info = dev->fs_info;
> struct reada_extent *re = NULL;
> int mirror_num = 0;
> struct extent_buffer *eb = NULL;
> @@ -763,8 +763,7 @@ static void __reada_start_machine(struct btrfs_fs_info *fs_info)
> list_for_each_entry(device, &fs_devices->devices, dev_list) {
> if (atomic_read(&device->reada_in_flight) <
> MAX_IN_FLIGHT)
> - enqueued += reada_start_machine_dev(fs_info,
> - device);
> + enqueued += reada_start_machine_dev(device);
> }
> mutex_unlock(&fs_devices->device_list_mutex);
> total += enqueued;
> --
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-20 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 16:02 [PATCH 0/7] Readahead clenups David Sterba
2017-03-15 16:02 ` [PATCH 1/7] btrfs: preallocate radix tree node for readahead David Sterba
2017-03-20 20:40 ` Liu Bo
2017-03-15 16:02 ` [PATCH 2/7] btrfs: use simpler readahead zone lookups David Sterba
2017-03-20 20:44 ` Liu Bo
2017-03-31 17:33 ` David Sterba
2017-03-15 16:02 ` [PATCH 3/7] btrfs: preallocate radix tree node for global readahead tree David Sterba
2017-03-20 20:58 ` Liu Bo
2017-03-15 16:02 ` [PATCH 4/7] btrfs: remove redundant parameter from btree_readahead_hook David Sterba
2017-03-20 21:00 ` Liu Bo
2017-03-15 16:02 ` [PATCH 5/7] btrfs: remove redundant parameter from reada_find_zone David Sterba
2017-03-20 21:03 ` Liu Bo
2017-03-15 16:02 ` [PATCH 6/7] btrfs: remove redundant parameter from reada_start_machine_dev David Sterba
2017-03-20 21:04 ` Liu Bo [this message]
2017-03-15 16:02 ` [PATCH 7/7] btrfs: remove local blocksize variable in reada_find_extent David Sterba
2017-03-20 21:04 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320210420.GI5540@lim.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.