From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/6] drm/i915: Use i9xx_check_plane_surface() for sprite planes as well
Date: Mon, 27 Mar 2017 16:10:30 +0300 [thread overview]
Message-ID: <20170327131030.GK30290@intel.com> (raw)
In-Reply-To: <20170324103556.GD9495@nuc-i3427.alporthouse.com>
On Fri, Mar 24, 2017 at 10:35:56AM +0000, Chris Wilson wrote:
> On Thu, Mar 23, 2017 at 09:27:12PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > All the pre-SKL sprite planes compute the x/y/tile offsets in a
> > similar way. There are a couple of minor differences but the primary
> > planes have those as well. Thus i9xx_check_plane_surface()
> > already does what we need, so let's use it.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Looks right to me, but I'd recommend a second opinion here.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
I'm feeling lucky. Entire series pushed to dinq. Thanks for the
review.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-27 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 19:27 [PATCH v2 0/6] drm/i915: Moar plane update optimizations (v2) ville.syrjala
2017-03-23 19:27 ` [PATCH v2 1/6] drm/i915: Extract i9xx_plane_ctl() and ironlake_plane_ctl() ville.syrjala
2017-03-23 22:01 ` Chris Wilson
2017-03-23 19:27 ` [PATCH 2/6] drm/i915: Nuke ironlake_plane_ctl() ville.syrjala
2017-03-23 22:04 ` Chris Wilson
2017-03-23 19:27 ` [PATCH 3/6] drm/i915: Pre-compute plane control register value ville.syrjala
2017-03-23 19:27 ` [PATCH v2 4/6] drm/i915: Introduce i9xx_check_plane_surface() ville.syrjala
2017-03-23 19:27 ` [PATCH 5/6] drm/i915: Eliminate ironlake_update_primary_plane() ville.syrjala
2017-03-23 19:27 ` [PATCH 6/6] drm/i915: Use i9xx_check_plane_surface() for sprite planes as well ville.syrjala
2017-03-24 10:35 ` Chris Wilson
2017-03-27 13:10 ` Ville Syrjälä [this message]
2017-03-24 10:17 ` ✓ Fi.CI.BAT: success for drm/i915: Moar plane update optimizations (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327131030.GK30290@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.