From: Eduardo Valentin <edubezval@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
kernel@martin.sperl.org, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH V11 6/6] thermal: bcm2835: add thermal driver for bcm2835 SoC
Date: Wed, 29 Mar 2017 21:57:27 -0700 [thread overview]
Message-ID: <20170330045725.GA12995@localhost.localdomain> (raw)
In-Reply-To: <20170329045807.GC2582@localhost.localdomain>
On Tue, Mar 28, 2017 at 09:58:09PM -0700, Eduardo Valentin wrote:
> On Sun, Mar 12, 2017 at 10:11:05PM +0000, Stefan Wahren wrote:
> > Add basic thermal driver for bcm2835 SoC.
> >
> > This driver currently make sure that tsense HW block is set up
> > correctly.
> >
> > Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> > Acked-by: Eric Anholt <eric@anholt.net>
>
> I see no issue with this driver at this point.
>
> As I mentioned, the full series needs to go together. You either get an
> Ack from OF maintainers, and I take the series, or you can add my
>
> Acked-by: Eduardo Valentin <edubezval@gmail.com>
>
> after fixing the small comment from Nobuhiro.
>
Based on other drivers that require negative values, I assume patches 1
and 2 of these series are needed, but more for enforcing the API, given
that the current of-thermal driver still retrieves the negative values
from DTB [1].
A third option on top of what I suggested above is to split the series.
Given that you could still get the proper coefficients
with current of-thermal, I would suggest you to split this series into
two (patches 1-2, 3-6) in your next version, so we avoid futher delays
on the driver, while patches 1-2 waits for acks from OF side.
[1] - https://patchwork.kernel.org/patch/9612613/
next prev parent reply other threads:[~2017-03-30 4:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 22:10 [PATCH V11 0/6] thermal: bcm2835: add thermal driver for bcm2835 SoC Stefan Wahren
[not found] ` <1489356665-3175-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2017-03-12 22:11 ` [PATCH V11 1/6] of: base: Implement read function for s32 array Stefan Wahren
2017-03-23 23:26 ` Frank Rowand
2017-03-12 22:11 ` [PATCH V11 2/6] thermal: of-thermal: Implement signed coefficient support Stefan Wahren
[not found] ` <1489356665-3175-3-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2017-03-23 23:32 ` Frank Rowand
2017-03-24 7:27 ` Stefan Wahren
2017-03-24 17:23 ` Frank Rowand
2017-03-29 4:52 ` Eduardo Valentin
2017-03-29 4:54 ` Eduardo Valentin
2017-03-12 22:11 ` [PATCH V11 3/6] dt-bindings: Add thermal zone to bcm2835-thermal example Stefan Wahren
2017-03-12 22:11 ` [PATCH V11 4/6] ARM: dts: bcm283x: Add CPU thermal zone with 1 trip point Stefan Wahren
2017-03-12 22:11 ` [PATCH V11 5/6] ARM64: dts: bcm2837: Define CPU thermal coefficients Stefan Wahren
2017-03-12 22:11 ` [PATCH V11 6/6] thermal: bcm2835: add thermal driver for bcm2835 SoC Stefan Wahren
2017-03-23 16:53 ` Nobuhiro Iwamatsu
[not found] ` <CABMQnVJx10e2qm0N=C_vxU9WAQGUJ3ZyAUgrK7WQZoxm9+P0wg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-23 18:52 ` Stefan Wahren
[not found] ` <1489356665-3175-7-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2017-03-29 4:58 ` Eduardo Valentin
2017-03-30 4:57 ` Eduardo Valentin [this message]
[not found] ` <20170330045725.GA12995-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-03-30 6:30 ` Stefan Wahren
[not found] ` <1205844664.21224.1490855429497-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-03-31 1:08 ` Eduardo Valentin
2017-03-30 19:11 ` Stefan Wahren
[not found] ` <1620097357.332334.1490901102005-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-03-31 1:06 ` Eduardo Valentin
2017-03-22 19:30 ` [PATCH V11 0/6] " Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330045725.GA12995@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=kernel@martin.sperl.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.