All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH 05/10] cg3: remove TARGET_PAGE_SIZE rounding on dirty page detection
Date: Tue,  4 Apr 2017 12:23:10 +0200	[thread overview]
Message-ID: <20170404102315.24923-6-kraxel@redhat.com> (raw)
In-Reply-To: <20170404102315.24923-1-kraxel@redhat.com>

From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

This was an artifact from very early versions of the code from before the
memory API and is no longer needed.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/display/cg3.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/display/cg3.c b/hw/display/cg3.c
index 1174220..e05ca92 100644
--- a/hw/display/cg3.c
+++ b/hw/display/cg3.c
@@ -114,7 +114,7 @@ static void cg3_update_display(void *opaque)
     for (y = 0; y < height; y++) {
         int update = s->full_update;
 
-        page = (y * width) & TARGET_PAGE_MASK;
+        page = y * width;
         update |= memory_region_get_dirty(&s->vram_mem, page, page + width,
                                           DIRTY_MEMORY_VGA);
         if (update) {
@@ -148,8 +148,7 @@ static void cg3_update_display(void *opaque)
     }
     if (page_max >= page_min) {
         memory_region_reset_dirty(&s->vram_mem,
-                              page_min, page_max - page_min + TARGET_PAGE_SIZE,
-                              DIRTY_MEMORY_VGA);
+                              page_min, page_max - page_min, DIRTY_MEMORY_VGA);
     }
     /* vsync interrupt? */
     if (s->regs[0] & CG3_CR_ENABLE_INTS) {
-- 
2.9.3

  parent reply	other threads:[~2017-04-04 10:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 10:23 [Qemu-devel] [PATCH 00/10] make display updates thread safe Gerd Hoffmann
2017-04-04 10:23 ` [Qemu-devel] [PATCH 01/10] bitmap: add bitmap_copy_and_clear_atomic Gerd Hoffmann
2017-04-04 10:23 ` [Qemu-devel] [PATCH 02/10] memory: add support getting and using a dirty bitmap copy Gerd Hoffmann
2017-04-04 10:29   ` Paolo Bonzini
2017-04-04 10:23 ` [Qemu-devel] [PATCH 03/10] vga: add vga_scanline_invalidated helper Gerd Hoffmann
2017-04-15 10:39   ` Richard Henderson
2017-04-18  9:23     ` Gerd Hoffmann
2017-04-04 10:23 ` [Qemu-devel] [PATCH 04/10] vga: make display updates thread safe Gerd Hoffmann
2017-04-04 10:23 ` Gerd Hoffmann [this message]
2017-04-04 10:23 ` [Qemu-devel] [PATCH 06/10] cg3: fix up size parameter for memory_region_get_dirty() Gerd Hoffmann
2017-04-04 12:32   ` Mark Cave-Ayland
2017-04-04 10:23 ` [Qemu-devel] [PATCH 07/10] cg3: make display updates thread safe Gerd Hoffmann
2017-04-04 10:23 ` [Qemu-devel] [PATCH 08/10] tcx: introduce tcx_check_dirty() function Gerd Hoffmann
2017-04-04 10:23 ` [Qemu-devel] [PATCH 09/10] tcx: make display updates thread safe Gerd Hoffmann
2017-04-04 12:43   ` Mark Cave-Ayland
2017-04-04 10:23 ` [Qemu-devel] [PATCH 10/10] [testing] console: remove do_safe_dpy_refresh Gerd Hoffmann
2017-04-04 12:54 ` [Qemu-devel] [PATCH 00/10] make display updates thread safe Mark Cave-Ayland
2017-04-05  8:33   ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170404102315.24923-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.