From: Steven Rostedt <rostedt@goodmis.org>
To: Calvin Owens <calvinowens@fb.com>
Cc: "Petr Mladek" <pmladek@suse.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.cz>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Manuel Schölling" <manuel.schoelling@gmx.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Paul Burton" <paul.burton@imgtec.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [RFC][PATCH 2/2] printk: Add /sys/consoles/${con}/ and maxlevel attribute
Date: Tue, 4 Apr 2017 23:30:50 -0400 [thread overview]
Message-ID: <20170404233050.3afba596@gandalf.local.home> (raw)
In-Reply-To: <8d144e1ec0c18761c4a6e14353e49e81a81bc924.1491345440.git.calvinowens@fb.com>
On Tue, 4 Apr 2017 16:03:20 -0700
Calvin Owens <calvinowens@fb.com> wrote:
> This does the simplest possible thing: add a directory at the root of
> sysfs that allows setting the "maxlevel" parameter for each console.
>
> We can let kobject destruction race with console removal: if it does,
> maxlevel_{show,store}() will safely fail with -ENODEV. This is a little
> weird, but avoids embedding the kobject and therefore needing to totally
> refactor the way we handle console struct lifetime.
Can you also add a patch that allows this to be set on the kernel
command line, when the consoles are defined.
-- Steve
>
> Signed-off-by: Calvin Owens <calvinowens@fb.com>
next prev parent reply other threads:[~2017-04-05 3:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 23:02 [RFC][PATCH 1/2] printk: Introduce per-console filtering of messages by loglevel Calvin Owens
2017-04-04 23:03 ` [RFC][PATCH 2/2] printk: Add /sys/consoles/${con}/ and maxlevel attribute Calvin Owens
2017-04-05 3:30 ` Steven Rostedt [this message]
2017-04-05 23:55 ` Calvin Owens
2017-04-05 1:51 ` [RFC][PATCH 1/2] printk: Introduce per-console filtering of messages by loglevel Joe Perches
2017-04-05 2:08 ` Sergey Senozhatsky
2017-04-05 2:16 ` Sergey Senozhatsky
2017-04-05 3:27 ` Steven Rostedt
2017-04-05 23:53 ` Calvin Owens
2017-04-05 15:22 ` Petr Mladek
2017-04-06 0:38 ` Calvin Owens
2017-04-06 14:02 ` Petr Mladek
2017-04-06 22:52 ` Calvin Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404233050.3afba596@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=calvinowens@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jslaby@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=paul.burton@imgtec.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.