Re: [PATCH 03/13] drm/i915: Convert intel_dp_mst connector properties to atomic.

From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 03/13] drm/i915: Convert intel_dp_mst connector properties to atomic.
Date: Wed, 12 Apr 2017 09:40:35 +0200	[thread overview]
Message-ID: <20170412074035.yqkml7k5eoxrzg7h@phenom.ffwll.local> (raw)
In-Reply-To: <1491545282-815-4-git-send-email-maarten.lankhorst@linux.intel.com>

On Fri, Apr 07, 2017 at 08:07:52AM +0200, Maarten Lankhorst wrote:
> MST doesn't support setting any properties, but it should still
> use the atomic helper for setting properties.
> 
> Only path and tile properties are supported (read-only).
> Those are immutable, and handled by drm core.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_dp_mst.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> index c1f62eb07c07..3fc345a76e6f 100644
> --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> @@ -294,14 +294,6 @@ intel_dp_mst_detect(struct drm_connector *connector, bool force)
>  	return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
>  }
>  
> -static int
> -intel_dp_mst_set_property(struct drm_connector *connector,
> -			  struct drm_property *property,
> -			  uint64_t val)
> -{
> -	return 0;
> -}
> -
>  static void
>  intel_dp_mst_connector_destroy(struct drm_connector *connector)
>  {
> @@ -318,8 +310,7 @@ static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
>  	.dpms = drm_atomic_helper_connector_dpms,
>  	.detect = intel_dp_mst_detect,
>  	.fill_modes = drm_helper_probe_single_connector_modes,
> -	.set_property = intel_dp_mst_set_property,
> -	.atomic_get_property = intel_connector_atomic_get_property,
> +	.set_property = drm_atomic_helper_connector_set_property,
>  	.late_register = intel_connector_register,
>  	.early_unregister = intel_connector_unregister,
>  	.destroy = intel_dp_mst_connector_destroy,
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx