All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
	dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>
Subject: [PATCH v2 04/13] dm-rq: Adjust requeuing delays
Date: Thu, 27 Apr 2017 10:11:17 -0700	[thread overview]
Message-ID: <20170427171126.26814-5-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170427171126.26814-1-bart.vanassche@sandisk.com>

Reduce the requeue delay in dm_requeue_original_request() from 5s
to 0.5s to avoid that this delay slows down failover or failback.
Increase the requeue delay in dm_mq_queue_rq() from 0.1s to 0.5s
to reduce the system load if immediate requeuing has been requested
by the dm driver.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-rq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index 0b081d170087..c53debdcd7dc 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -280,7 +280,7 @@ static void dm_requeue_original_request(struct dm_rq_target_io *tio, bool delay_
 	if (!rq->q->mq_ops)
 		dm_old_requeue_request(rq);
 	else
-		dm_mq_delay_requeue_request(rq, delay_requeue ? 5000 : 0);
+		dm_mq_delay_requeue_request(rq, delay_requeue ? 500/*ms*/ : 0);
 
 	rq_completed(md, rw, false);
 }
@@ -755,7 +755,7 @@ static int dm_mq_queue_rq(struct blk_mq_hw_ctx *hctx,
 		/* Undo dm_start_request() before requeuing */
 		rq_end_stats(md, rq);
 		rq_completed(md, rq_data_dir(rq), false);
-		blk_mq_delay_run_hw_queue(hctx, 100/*ms*/);
+		blk_mq_delay_run_hw_queue(hctx, 500/*ms*/);
 		return BLK_MQ_RQ_QUEUE_BUSY;
 	}
 
-- 
2.12.2

  parent reply	other threads:[~2017-04-27 17:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 17:11 [PATCH v2 00/13] Device mapper and dm-mpath patches Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 01/13] dm-mpath: Split activate_path() Bart Van Assche
2017-04-27 17:11   ` Bart Van Assche
2017-04-28  5:59   ` [dm-devel] " Hannes Reinecke
2017-04-28  5:59     ` Hannes Reinecke
2017-04-27 17:11 ` [PATCH v2 02/13] dm-mpath: Avoid that path removal can trigger an infinite loop Bart Van Assche
2017-04-27 17:11   ` Bart Van Assche
2017-04-28  5:59   ` [dm-devel] " Hannes Reinecke
2017-04-28  5:59     ` Hannes Reinecke
2017-04-27 17:11 ` [PATCH v2 03/13] dm-mpath: Delay requeuing while path initialization is in progress Bart Van Assche
2017-04-27 17:11   ` Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche [this message]
2017-04-27 19:16   ` [PATCH v2 04/13] dm-rq: Adjust requeuing delays Mike Snitzer
2017-04-27 19:52     ` Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 05/13] dm-mpath: Make it easier to analyze requeuing behavior Bart Van Assche
2017-04-27 19:29   ` Mike Snitzer
2017-04-27 19:57     ` Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 06/13] dm-rq: Check blk_mq_register_dev() return value Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 07/13] dm, persistence: Remove an unused argument from dm_block_manager_create() Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 08/13] dm: Verify suspend_locking assumptions at runtime Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 09/13] dm-mpath: Verify locking " Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 10/13] dm: Introduce enum dm_queue_mode Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 11/13] dm-mpath: Micro-optimize the hot path Bart Van Assche
2017-04-27 20:39   ` Mike Snitzer
2017-04-27 17:11 ` [PATCH v2 12/13] dm-mpath: Introduce assign_bit() Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 13/13] dm, dm-mpath: Make it easier to detect unintended I/O request flushes Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170427171126.26814-5-bart.vanassche@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.