Re: [PATCH -next v2] input: touchscreen: mxs-lradc: Fix return value check in mxs_lradc_ts_probe()

From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>, Marek Vasut <marex@denx.de>,
	Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH -next v2] input: touchscreen: mxs-lradc: Fix return value check in mxs_lradc_ts_probe()
Date: Fri, 28 Apr 2017 08:43:14 +0100	[thread overview]
Message-ID: <20170428074314.dd63j6smcer2ndqw@dell> (raw)
In-Reply-To: <20170427165244.GA33675@dtor-ws>

On Thu, 27 Apr 2017, Dmitry Torokhov wrote:

> On Thu, Apr 27, 2017 at 03:13:52PM +0000, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > In case of error, the function devm_ioremap() returns NULL pointer not
> > ERR_PTR(). Use devm_ioremap_resource() instead of devm_ioremap().
> > 
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Lee, could you please pick this one up as well?

You'll have to pick this up for -fixes.

I've already tagged MFD for Sunday's merge-window.

> > ---
> > v1 -> v2: use devm_ioremap_resource()
> > ---
> >  drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
> > index 4b4aebf..2c5076c 100644
> > --- a/drivers/input/touchscreen/mxs-lradc-ts.c
> > +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> > @@ -630,7 +630,7 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
> >  	spin_lock_init(&ts->lock);
> >  
> >  	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	ts->base = devm_ioremap(dev, iores->start, resource_size(iores));
> > +	ts->base = devm_ioremap_resource(dev, iores);
> >  	if (IS_ERR(ts->base))
> >  		return PTR_ERR(ts->base);
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog