From: Theodore Ts'o <tytso@mit.edu>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
Richard Weinberger <richard@nod.at>,
Michael Halcrow <mhalcrow@google.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [1/4] fscrypt: fix context consistency check when key(s) unavailable
Date: Thu, 4 May 2017 11:49:40 -0400 [thread overview]
Message-ID: <20170504154940.6kof2mn3p4oo6vnj@thunk.org> (raw)
In-Reply-To: <20170502173601.GA75651@gmail.com>
On Tue, May 02, 2017 at 10:36:01AM -0700, Eric Biggers wrote:
> Ted, can you add Cc stable to this commit? (Just this one; the others in the
> series aren't as important.) I think this fix is more important than I
> originally thought, because it's actually pretty easy to end up in a situation
> where a directory has its key but a file in it does not, due to the file's inode
> having been evicted from the inode cache but not the directory's inode. This
> makes the file undeletable.
Done. This meant I had to do a rewind on the fscrypt tree, so if
someone has built something on top of fscrypt since Sunday you may
need to take special precautions. This was just a change to the
commit description so git rebase should take of the problem relatively
easily.
- Ted
next prev parent reply other threads:[~2017-05-04 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 17:58 [PATCH 0/4] fscrypt context consistency check fixes Eric Biggers
2017-04-07 17:58 ` [PATCH 1/4] fscrypt: fix context consistency check when key(s) unavailable Eric Biggers
2017-04-30 6:17 ` [1/4] " Theodore Ts'o
2017-05-02 17:36 ` Eric Biggers
2017-05-04 15:49 ` Theodore Ts'o [this message]
2017-04-07 17:58 ` [PATCH 2/4] ext4: remove "nokey" check from ext4_lookup() Eric Biggers
2017-04-30 6:17 ` [2/4] " Theodore Ts'o
2017-04-07 17:58 ` [PATCH 3/4] f2fs: sync f2fs_lookup() with ext4_lookup() Eric Biggers
2017-04-30 6:18 ` [3/4] " Theodore Ts'o
2017-04-07 17:58 ` [PATCH 4/4] ubifs: check for consistent encryption contexts in ubifs_lookup() Eric Biggers
2017-04-30 6:18 ` [4/4] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504154940.6kof2mn3p4oo6vnj@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mhalcrow@google.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.