From: Benjamin Valentin <benpicco@googlemail.com>
To: Cameron Gutman <aicommander@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Pavel Rojtberg <rojtberg@gmail.com>,
"Pierre-Loup A. Griffais" <eduke32@plagman.net>,
Daniel Tobias <dan.g.tob@gmail.com>
Subject: Re: [PATCHv2] Input: xpad - sync supported devices with 360Controller
Date: Fri, 12 May 2017 00:22:42 +0200 [thread overview]
Message-ID: <20170512002242.6a8d8a69@nashorn> (raw)
In-Reply-To: <dbd402c4-b1e5-80da-b9d3-670bb2e0c829@gmail.com>
On Mon, 8 May 2017 22:18:49 -0700
Cameron Gutman <aicommander@gmail.com> wrote:
> It looks like you dropped a few entries from xpad_table[]. With that
> table, I'd rather just list the VIDs and risk a chance it's wrong and
> doesn't work than not list it and guarantee 100% that it won't work.
> If the interface descriptor doesn't look right to us, we won't touch
> it anyway.
Well I'm not so sure about how valid they were.
0810:0003 Trust Predator
actually seems to be a PlayStation Gamepad/Adapter according to the
USB ID Repository. [0]
Game-Debate [1] confirms this.
11c0:5506 BETOP GAMEFORWINDOWS
is most likely BTP-2175 [2] which can also switch to DirectInput/HID mode (?)
where it aleady works out of the box with Linux [3] so this might possibly
break things. Or enable things as I'm not sure if the HID driver supports the rumble
functionality.
360Controller detects it as Xbox 360 Controller on OS X [4] with this ID, so it might actually
be a good idea to add it back.
> I also have a few name nits to throw in your respin.
I will address those in v3
[0] https://usb-ids.gowdy.us/read/UD/0810/0003
[1] http://www.game-debate.com/gamepad/index.php?ga_id=41&gamepad=Trust%20Predator
[2] https://www.banggood.com/de/Betop-BTP-2175-Asura-Double-Vibration-Computer-Game-Controller-p-1063903.html
[3] http://unsolicitedbutoffered.blogspot.de/2017/04/tested-betop-controller-with-fedora-25.html
[4] http://unsolicitedbutoffered.blogspot.de/2017/05/tested-betop-controller-openemu_7.html
next prev parent reply other threads:[~2017-05-11 22:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 21:15 [PATCH 1/2] Input: xpad - sort supported devices by USB ID Benjamin Valentin
2017-05-04 21:17 ` [PATCH 2/2] Input: xpad - sync supported devices with xboxdrv Benjamin Valentin
2017-05-04 22:47 ` Input: xpad - add USB IDs for Mad Catz Brawlstick and Razer Sabertooth Benjamin Valentin
2017-05-05 0:04 ` Cameron Gutman
2017-05-04 23:52 ` [PATCH 2/2] Input: xpad - sync supported devices with xboxdrv Cameron Gutman
2017-05-05 17:50 ` [PATCH v2 " Benjamin Valentin
2017-05-06 4:25 ` Cameron Gutman
2017-05-06 17:10 ` [PATCH] Input: xpad - sync supported devices with 360Controller Benjamin Valentin
2017-05-06 21:19 ` Cameron Gutman
2017-05-07 21:53 ` Dmitry Torokhov
2017-05-09 0:52 ` [PATCHv2] " Benjamin Valentin
2017-05-09 5:18 ` Cameron Gutman
2017-05-11 22:22 ` Benjamin Valentin [this message]
2017-05-13 3:08 ` Cameron Gutman
2017-05-14 18:05 ` [PATCHv3] " Benjamin Valentin
2017-05-14 19:52 ` Cameron Gutman
2017-05-14 20:28 ` [PATCHv4] " Cameron Gutman
2017-05-08 23:08 ` [PATCH] " Benjamin Valentin
2017-05-16 23:01 ` [PATCH] Input: xpad - sync supported devices with XBCD Benjamin Valentin
2017-05-21 23:38 ` Cameron Gutman
2017-05-05 0:09 ` [PATCH 1/2] Input: xpad - sort supported devices by USB ID Cameron Gutman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512002242.6a8d8a69@nashorn \
--to=benpicco@googlemail.com \
--cc=aicommander@gmail.com \
--cc=dan.g.tob@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eduke32@plagman.net \
--cc=linux-input@vger.kernel.org \
--cc=rojtberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.