From: Stefan Hajnoczi <stefanha@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org
Subject: Re: vhost/scsi: Delete error messages for failed memory allocations in five functions
Date: Mon, 22 May 2017 15:09:35 +0100 [thread overview]
Message-ID: <20170522140935.GB1021__31839.6309893162$1495462215$gmane$org@stefanha-x1.localdomain> (raw)
In-Reply-To: <e6658e56-a2b0-4ecc-0a95-0ba193ff2c97@users.sourceforge.net>
[-- Attachment #1.1: Type: text/plain, Size: 861 bytes --]
On Mon, May 22, 2017 at 01:34:34PM +0200, SF Markus Elfring wrote:
> >> Do you find information from a Linux allocation failure report sufficient
> >> for any function implementations here?
> >
> > If kmalloc() and friends guarantee to print a warning and backtrace on
> > every allocation failure, then there's no need for error messages in
> > callers.
> >
> > That seems like good justification that can go in the commit
> > description, but I'm not sure if kmalloc() and friends guarantee to show
> > a message (not just the first time, but for every failed allocation)?
>
> I am also looking for a more complete and easier accessible documentation
> for this aspect of the desired exception handling.
> How would we like to resolve any remaining open issues there?
No objection from me but please make sure to keep vq_err().
Stefan
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2017-05-22 14:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 14:30 [PATCH 0/2] vhost/scsi: Adjustments for five function implementations SF Markus Elfring
2017-05-20 14:30 ` SF Markus Elfring
2017-05-20 14:31 ` [PATCH 1/2] vhost/scsi: Improve a size determination in four functions SF Markus Elfring
2017-05-20 14:31 ` SF Markus Elfring
2017-05-22 9:37 ` Stefan Hajnoczi
2017-05-22 9:37 ` Stefan Hajnoczi
2017-05-22 9:37 ` Stefan Hajnoczi
2017-05-20 14:31 ` SF Markus Elfring
2017-05-20 14:32 ` [PATCH 2/2] vhost/scsi: Delete error messages for failed memory allocations in five functions SF Markus Elfring
2017-05-20 14:32 ` SF Markus Elfring
2017-05-22 9:43 ` Stefan Hajnoczi
2017-05-22 9:43 ` Stefan Hajnoczi
2017-05-22 9:43 ` Stefan Hajnoczi
2017-05-22 10:50 ` SF Markus Elfring
2017-05-22 10:50 ` SF Markus Elfring
2017-05-22 10:50 ` SF Markus Elfring
2017-05-22 11:23 ` Stefan Hajnoczi
2017-05-22 11:23 ` Stefan Hajnoczi
2017-05-22 11:23 ` Stefan Hajnoczi
2017-05-22 11:34 ` SF Markus Elfring
2017-05-22 11:34 ` SF Markus Elfring
2017-05-22 11:34 ` SF Markus Elfring
2017-05-22 14:09 ` Stefan Hajnoczi [this message]
2017-05-22 14:09 ` Stefan Hajnoczi
2017-05-22 14:09 ` Stefan Hajnoczi
2017-05-22 14:21 ` SF Markus Elfring
2017-05-22 14:21 ` SF Markus Elfring
2017-05-22 14:21 ` SF Markus Elfring
2017-05-22 12:38 ` [PATCH 2/2] " Dan Carpenter
2017-05-22 12:38 ` Dan Carpenter
2017-05-22 12:38 ` Dan Carpenter
2017-05-22 14:08 ` Stefan Hajnoczi
2017-05-22 14:08 ` Stefan Hajnoczi
2017-05-22 14:08 ` Stefan Hajnoczi
2017-05-20 14:32 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20170522140935.GB1021__31839.6309893162$1495462215$gmane$org@stefanha-x1.localdomain' \
--to=stefanha@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.