From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH 3/7] osstest: fix regular expression used to match buildjob in ts-build-check
Date: Wed, 24 May 2017 08:18:23 +0100 [thread overview]
Message-ID: <20170524071823.ytqj4fvwtaxrcvaa@MacBook-Pro-de-Roger.local> (raw)
In-Reply-To: <22820.20173.812319.42306@mariner.uk.xensource.com>
On Tue, May 23, 2017 at 04:01:33PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH 3/7] osstest: fix regular expression used to match buildjob in ts-build-check"):
> > Current regular expression used to match the buildjob works correctly when the
> > buildjob runvar has the <job_name>buildjob format, but not when the format is
> > <job_name>_buildjob (the first match group is empty in this case). Change it so
> > that it works for both formats.
>
> I think I have misled you. Looking at the database I see there are
> runvars with names like this
>
> src_host_xenbuildjob
> guests_rumpuserxenbuildjob
>
> Ie, the part before the _ (if any), is a scope (like a host ident).
> So this patch is wrong, and also, your other patches have to use
> `freebsdbuildjob'.
>
> Sorry :-/.
NP, it's a simple s/freebsd_buildjob/freebsdbuildjob/, now done (and this patch
dropped).
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-24 7:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 13:51 [PATCH 0/7] osstest: initial FreeBSD support Roger Pau Monne
2017-05-23 13:51 ` [PATCH 1/7] osstest: make built_stash_file store a path_ runvar for each file Roger Pau Monne
2017-05-23 14:55 ` Ian Jackson
2017-05-23 13:51 ` [PATCH 2/7] osstest: move known_hosts generation to TestSupport Roger Pau Monne
2017-05-23 14:56 ` Ian Jackson
2017-05-23 13:51 ` [PATCH 3/7] osstest: fix regular expression used to match buildjob in ts-build-check Roger Pau Monne
2017-05-23 15:01 ` Ian Jackson
2017-05-24 7:18 ` Roger Pau Monne [this message]
2017-05-23 13:51 ` [PATCH 4/7] osstest: add a FreeBSD host install recipe Roger Pau Monne
2017-05-23 16:04 ` Ian Jackson
2017-05-24 10:48 ` Roger Pau Monne
2017-05-24 11:12 ` Ian Jackson
2017-05-23 17:14 ` Ian Jackson
2017-05-23 13:51 ` [PATCH 5/7] osstest: introduce a FreeBSD build script Roger Pau Monne
2017-05-23 17:58 ` Ian Jackson
2017-05-24 14:15 ` Roger Pau Monne
2017-05-24 14:19 ` Ian Jackson
2017-05-23 13:51 ` [PATCH 6/7] osstest: add a FreeBSD build to flights Roger Pau Monne
2017-05-23 13:51 ` [PATCH 7/7] osstest: introduce make-freebsd-flight Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524071823.ytqj4fvwtaxrcvaa@MacBook-Pro-de-Roger.local \
--to=roger.pau@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.