All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <dsterba@suse.cz>, <lakshmipathi.g@gmail.com>
Subject: [PATCH v4 13/20] btrfs-progs: scrub: Introduce function to scrub one data stripe
Date: Thu, 25 May 2017 14:21:58 +0800	[thread overview]
Message-ID: <20170525062205.11660-14-quwenruo@cn.fujitsu.com> (raw)
In-Reply-To: <20170525062205.11660-1-quwenruo@cn.fujitsu.com>

Introduce new function, scrub_one_data_stripe(), to check all data and
tree blocks inside the data stripe.

This function will not try to recovery any error, but only check if any
data/tree blocks has mismatch csum.

If data missing csum, which is completely valid for case like nodatasum,
it will just record it, but not report as error.

Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
 scrub.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 129 insertions(+)

diff --git a/scrub.c b/scrub.c
index 4302aafa..1944f216 100644
--- a/scrub.c
+++ b/scrub.c
@@ -627,3 +627,132 @@ invalid_arg:
 	error("invalid parameter for %s", __func__);
 	return -EINVAL;
 }
+
+/*
+ * Scrub one full data stripe of RAID5/6.
+ * This means it will check any data/metadata extent in the data stripe
+ * spcified by @stripe and @stripe_len
+ *
+ * This function will only *CHECK* if the data stripe has any corruption.
+ * Won't repair at this function.
+ *
+ * Return 0 if the full stripe is OK.
+ * Return <0 if any error is found.
+ * Note: Missing csum is not counted as error(NODATACSUM is valid)
+ */
+static int scrub_one_data_stripe(struct btrfs_fs_info *fs_info,
+				 struct btrfs_scrub_progress *scrub_ctx,
+				 struct scrub_stripe *stripe, u32 stripe_len)
+{
+	struct btrfs_path *path;
+	struct btrfs_root *extent_root = fs_info->extent_root;
+	struct btrfs_key key;
+	u64 extent_start;
+	u64 extent_len;
+	u64 orig_csum_discards;
+	int ret;
+
+	if (!is_data_stripe(stripe))
+		return -EINVAL;
+
+	path = btrfs_alloc_path();
+	if (!path)
+		return -ENOMEM;
+
+	key.objectid = stripe->logical + stripe_len;
+	key.offset = 0;
+	key.type = 0;
+
+	ret = btrfs_search_slot(NULL, extent_root, &key, path, 0, 0);
+	if (ret < 0)
+		goto out;
+	while (1) {
+		struct btrfs_extent_item *ei;
+		struct extent_buffer *eb;
+		char *data;
+		int slot;
+		int metadata = 0;
+		u64 check_start;
+		u64 check_len;
+
+		ret = btrfs_previous_extent_item(extent_root, path, 0);
+		if (ret > 0) {
+			ret = 0;
+			goto out;
+		}
+		if (ret < 0)
+			goto out;
+		eb = path->nodes[0];
+		slot = path->slots[0];
+		btrfs_item_key_to_cpu(eb, &key, slot);
+		extent_start = key.objectid;
+		ei = btrfs_item_ptr(eb, slot, struct btrfs_extent_item);
+
+		/* tree block scrub */
+		if (key.type == BTRFS_METADATA_ITEM_KEY ||
+		    btrfs_extent_flags(eb, ei) & BTRFS_EXTENT_FLAG_TREE_BLOCK) {
+			extent_len = extent_root->nodesize;
+			metadata = 1;
+		} else {
+			extent_len = key.offset;
+			metadata = 0;
+		}
+
+		/* Current extent is out of our range, loop comes to end */
+		if (extent_start + extent_len <= stripe->logical)
+			break;
+
+		if (metadata) {
+			/*
+			 * Check crossing stripe first, which can't be scrubbed
+			 */
+			if (check_crossing_stripes(fs_info, extent_start,
+					extent_root->nodesize)) {
+				error("tree block at %llu is crossing stripe boundary, unable to scrub",
+					extent_start);
+				ret = -EIO;
+				goto out;
+			}
+			data = stripe->data + extent_start - stripe->logical;
+			ret = check_tree_mirror(fs_info, scrub_ctx,
+						data, extent_start, 0);
+			/* Any csum/verify error means the stripe is screwed */
+			if (ret < 0) {
+				stripe->csum_mismatch = 1;
+				ret = -EIO;
+				goto out;
+			}
+			ret = 0;
+			continue;
+		}
+		/* Restrict the extent range to fit stripe range */
+		check_start = max(extent_start, stripe->logical);
+		check_len = min(extent_start + extent_len, stripe->logical +
+				stripe_len) - check_start;
+
+		/* Record original csum_discards to detect missing csum case */
+		orig_csum_discards = scrub_ctx->csum_discards;
+
+		data = stripe->data + check_start - stripe->logical;
+		ret = check_data_mirror(fs_info, scrub_ctx, data, check_start,
+					check_len, 0, NULL);
+		/* Csum mismatch, no need to continue anyway*/
+		if (ret < 0) {
+			stripe->csum_mismatch = 1;
+			goto out;
+		}
+		/* Check if there is any missing csum for data */
+		if (scrub_ctx->csum_discards != orig_csum_discards)
+			stripe->csum_missing = 1;
+		/*
+		 * Only increase data_extents_scrubbed if we are scrubbing the
+		 * tailing part of the data extent
+		 */
+		if (extent_start + extent_len <= stripe->logical + stripe_len)
+			scrub_ctx->data_extents_scrubbed++;
+		ret = 0;
+	}
+out:
+	btrfs_free_path(path);
+	return ret;
+}
-- 
2.13.0




  parent reply	other threads:[~2017-05-25  6:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  6:21 [PATCH v4 00/20] Btrfs-progs offline scrub Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 01/20] btrfs-progs: raid56: Introduce raid56 header for later recovery usage Qu Wenruo
2017-05-31 13:25   ` David Sterba
2017-05-25  6:21 ` [PATCH v4 02/20] btrfs-progs: raid56: Introduce tables for RAID6 recovery Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 03/20] btrfs-progs: raid56: Allow raid6 to recover 2 data stripes Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 04/20] btrfs-progs: raid56: Allow raid6 to recover data and p Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 05/20] btrfs-progs: Introduce wrapper to recover raid56 data Qu Wenruo
2017-05-31 13:52   ` David Sterba
2017-06-01  1:04     ` Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 06/20] btrfs-progs: Introduce new btrfs_map_block function which returns more unified result Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 07/20] btrfs-progs: Allow __btrfs_map_block_v2 to remove unrelated stripes Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 08/20] btrfs-progs: csum: Introduce function to read out data csums Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 09/20] btrfs-progs: scrub: Introduce structures to support offline scrub for RAID56 Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 10/20] btrfs-progs: scrub: Introduce functions to scrub mirror based tree block Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 11/20] btrfs-progs: scrub: Introduce functions to scrub mirror based data blocks Qu Wenruo
2017-05-25  6:21 ` [PATCH v4 12/20] btrfs-progs: scrub: Introduce function to scrub one mirror-based extent Qu Wenruo
2017-05-25  6:21 ` Qu Wenruo [this message]
2017-05-25  6:21 ` [PATCH v4 14/20] btrfs-progs: scrub: Introduce function to verify parities Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 15/20] btrfs-progs: extent-tree: Introduce function to check if there is any extent in given range Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 16/20] btrfs-progs: scrub: Introduce function to recover data parity Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 17/20] btrfs-progs: scrub: Introduce helper to write a full stripe Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 18/20] btrfs-progs: scrub: Introduce a function to scrub one " Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 19/20] btrfs-progs: scrub: Introduce function to check a whole block group Qu Wenruo
2017-05-25  6:22 ` [PATCH v4 20/20] btrfs-progs: scrub: Introduce offline scrub function Qu Wenruo
2017-05-26 18:37 ` [PATCH v4 00/20] Btrfs-progs offline scrub Goffredo Baroncelli
2017-05-29  0:21   ` Qu Wenruo
2017-05-29 16:52     ` Goffredo Baroncelli
2017-05-30 18:54 ` David Sterba
2017-05-31 14:07   ` David Sterba
2017-06-18  6:20 ` Lakshmipathi.G

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525062205.11660-14-quwenruo@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=lakshmipathi.g@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.