Re: [PATCH 13/15] mfd: smsc-ece: use devm_of_platform_populate()

From: Lee Jones <lee.jones@linaro.org>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/15] mfd: smsc-ece: use devm_of_platform_populate()
Date: Tue, 30 May 2017 10:32:20 +0100	[thread overview]
Message-ID: <20170530093220.5jufyjbg5q5olbft@dell> (raw)
In-Reply-To: <1496072763-31209-14-git-send-email-benjamin.gaignard@linaro.org>

On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate
> is called when removing the driver.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> 
> CC: Lee Jones <lee.jones@linaro.org>
> CC: linux-kernel@vger.kernel.org
> ---
>  drivers/mfd/smsc-ece1099.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
> index 1f40baf..93a8297 100644
> --- a/drivers/mfd/smsc-ece1099.c
> +++ b/drivers/mfd/smsc-ece1099.c
> @@ -69,8 +69,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c,
>  
>  #ifdef CONFIG_OF
>  	if (i2c->dev.of_node)
> -		ret = of_platform_populate(i2c->dev.of_node,
> -					   NULL, NULL, &i2c->dev);
> +		ret = devm_of_platform_populate(&i2c->dev);
>  #endif
>  
>  	return ret;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog