From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-next] tools/libxc: Drop broken xc_{get, set}_hvm_param() functions
Date: Wed, 31 May 2017 12:41:49 +0100 [thread overview]
Message-ID: <20170531114149.6rplgoi5v7zapfus@citrix.com> (raw)
In-Reply-To: <c9d63776-6a6b-d99b-e509-8ce489cbcdf9@citrix.com>
On Wed, May 31, 2017 at 12:02:57PM +0100, Andrew Cooper wrote:
> On 31/05/17 11:35, Wei Liu wrote:
> > On Mon, May 22, 2017 at 12:50:09PM +0100, Andrew Cooper wrote:
> >> xc_{get,set}_hvm_param() are deprecated because they truncate their value
> >> parameter in 32bit builds of libxc, and are therefore unfit for use.
> >>
> >> As there is only a single remaining user, switch that user over to
> >> xc_hvm_param_get() and drop these functions completely.
> >>
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > This broke QEMU build because QEMU uses those.
>
> Which qemu? trad or upstream? I didn't encounter build errors myself.
>
qemu-trad.
https://travis-ci.org/xen-project/xen/jobs/237861522
> OTOH, my commit statement still stands. These functions are provably
> unfit for purpose, and need to be gotten rid of.
>
Yes. Please submit a patch to qemu-trad to switch to newer functions
first, then I can revert the revert.
Wei.
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-05-31 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 11:50 [PATCH for-next] tools/libxc: Drop broken xc_{get, set}_hvm_param() functions Andrew Cooper
2017-05-30 10:38 ` Wei Liu
2017-05-31 10:35 ` Wei Liu
2017-05-31 11:02 ` Andrew Cooper
2017-05-31 11:41 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531114149.6rplgoi5v7zapfus@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.