Re: [Qemu-devel] [Qemu-block] [PATCH v2] block: Do not strcmp() with NULL uri->scheme

From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	qemu-stable@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2] block: Do not strcmp() with NULL uri->scheme
Date: Thu, 15 Jun 2017 11:49:10 +0100	[thread overview]
Message-ID: <20170615104910.GB27346@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170613205726.13544-1-mreitz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

On Tue, Jun 13, 2017 at 10:57:26PM +0200, Max Reitz wrote:
> uri_parse(...)->scheme may be NULL. In fact, probably every field may be
> NULL, and the callers do test this for all of the other fields but not
> for scheme (except for block/gluster.c; block/vxhs.c does not access
> that field at all).
> 
> We can easily fix this by using g_strcmp0() instead of strcmp().
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> v2:
> - Fix all affected block drivers, not just nfs [Peter]
> - Use g_strcmp0() [Markus]
> ---
>  block/nbd.c      | 6 +++---
>  block/nfs.c      | 2 +-
>  block/sheepdog.c | 6 +++---
>  block/ssh.c      | 2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]