From: Matthias Kaehlcke <mka@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: kbuild-all@01.org, "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Michal Marek" <mmarek@suse.com>, "X86 ML" <x86@kernel.org>,
"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Michael Davidson" <md@google.com>,
"Greg Hackmann" <ghackmann@google.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Stephen Hines" <srhines@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bernhard Rosenkränzer" <Bernhard.Rosenkranzer@linaro.org>,
"Peter Foley" <pefoley2@pefoley.com>,
"Behan Webster" <behanw@converseincode.com>,
"Douglas Anderson" <dianders@chromium.org>,
"kbuild test robot" <lkp@intel.com>
Subject: Re: [PATCH v3 1/3] kbuild: Add __cc-option macro
Date: Mon, 19 Jun 2017 09:42:17 -0700 [thread overview]
Message-ID: <20170619164217.GO141096@google.com> (raw)
In-Reply-To: <CAK7LNAT2Aiz=k09N6AtE6pNvKh8yx=vaJBu49xzjEmv3JCiEBg@mail.gmail.com>
Hi Masahiro,
El Mon, Jun 19, 2017 at 11:00:42AM +0900 Masahiro Yamada ha dit:
> Sorry, the code I suggested introduced a slight behavior change.
>
> With this patch, cc-option adds a space before the returned option.
>
>
> Please see line 46 of arch/sh/Makefile.
>
> ifeq ($(cflags-y),)
>
>
> Now cflags-y contains a space, so
> this conditional is now evaluated as false,
> which was actually true without the patch.
> This is the cause of the build error.
Thanks for looking into this, I also didn't realize that the extra
space could be an issue.
> Could you remove whitespaces before $(1) and $(2) in cc-option?
>
> Also, please fix hostcc-option as well.
Sure, I'll send out a new version soon.
> 2017-06-18 15:58 GMT+09:00 kbuild test robot <lkp@intel.com>:
> > Hi Matthias,
> >
> > [auto build test ERROR on tip/auto-latest]
> > [also build test ERROR on v4.12-rc5 next-20170616]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/kbuild-Add-__cc-option-macro/20170616-082252
> > config: sh-sh7710voipgw_defconfig (attached as .config)
> > compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> > reproduce:
> > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > make.cross ARCH=sh
> >
> > All errors (new ones prefixed by >>):
> >
> > {standard input}: Assembler messages:
> >>> {standard input}:672: Error: invalid operands for opcode
> > {standard input}:673: Error: opcode not valid for this cpu variant
> > {standard input}:674: Error: opcode not valid for this cpu variant
> > {standard input}:675: Error: invalid operands for opcode
> > {standard input}:1900: Error: invalid operands for opcode
> > {standard input}:1901: Error: opcode not valid for this cpu variant
> > {standard input}:1902: Error: opcode not valid for this cpu variant
> > {standard input}:1903: Error: invalid operands for opcode
> > {standard input}:2067: Error: invalid operands for opcode
> > {standard input}:2068: Error: opcode not valid for this cpu variant
> > {standard input}:2069: Error: opcode not valid for this cpu variant
> > {standard input}:2070: Error: invalid operands for opcode
> > {standard input}:2570: Error: invalid operands for opcode
> > {standard input}:2571: Error: opcode not valid for this cpu variant
> > {standard input}:2572: Error: opcode not valid for this cpu variant
> > {standard input}:2573: Error: invalid operands for opcode
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
>
>
next prev parent reply other threads:[~2017-06-19 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 17:37 [PATCH v3 0/3] x86: stack alignment for boot code and clang Matthias Kaehlcke
2017-06-15 17:37 ` [PATCH v3 1/3] kbuild: Add __cc-option macro Matthias Kaehlcke
2017-06-16 0:48 ` Masahiro Yamada
2017-06-18 6:58 ` kbuild test robot
2017-06-18 6:58 ` kbuild test robot
2017-06-19 2:00 ` Masahiro Yamada
2017-06-19 16:42 ` Matthias Kaehlcke [this message]
2017-06-15 17:37 ` [PATCH v3 2/3] x86/build: Use __cc-option for boot code compiler options Matthias Kaehlcke
2017-06-15 17:37 ` [PATCH v3 3/3] x86/build: Specify stack alignment for clang Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619164217.GO141096@google.com \
--to=mka@chromium.org \
--cc=Bernhard.Rosenkranzer@linaro.org \
--cc=arnd@arndb.de \
--cc=behanw@converseincode.com \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=ghackmann@google.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=md@google.com \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
--cc=ndesaulniers@google.com \
--cc=pefoley2@pefoley.com \
--cc=srhines@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.