From: Mark Brown <broonie@kernel.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
amd-gfx@lists.freedesktop.org, rajeevkumar.linux@gmail.com,
dri-devel@lists.freedesktop.org, Vijendar.Mukunda@amd.com,
Alex Deucher <alexander.deucher@amd.com>,
perex@perex.cz
Subject: Re: [PATCH 3/8] drm/amd/amdgpu: Added a dwc quirk for Stoney platform
Date: Wed, 28 Jun 2017 19:02:35 +0100 [thread overview]
Message-ID: <20170628180235.2dscruiilz37gtr3@sirena.org.uk> (raw)
In-Reply-To: <1498235706-31111-4-git-send-email-alexander.deucher@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 467 bytes --]
On Fri, Jun 23, 2017 at 12:35:01PM -0400, Alex Deucher wrote:
> + if (adev->asic_type == CHIP_STONEY) {
> + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET |
> + DW_I2S_QUIRK_COMP_PARAM1 |
> + DW_I2S_QUIRK_16BIT_IDX_OVERRIDE;
> + } else {
> + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET |
> + DW_I2S_QUIRK_COMP_PARAM1;
> + }
Quirks like this are better written as switch statements since that
makes it easier to handle further variants in future.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-06-28 18:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 16:34 [PATCH 0/8] Add ASoC support for AMD Stoney APUs Alex Deucher
2017-06-23 16:35 ` [PATCH 3/8] drm/amd/amdgpu: Added a dwc quirk for Stoney platform Alex Deucher
2017-06-28 18:02 ` Mark Brown [this message]
2017-06-23 16:35 ` [PATCH 5/8] ASoC: AMD: DMA driver changes for Stoney Platform Alex Deucher
[not found] ` <1498235706-31111-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-06-23 16:34 ` [PATCH 1/8] drm/amd/amdgpu: Added asic_type as ACP DMA driver platform data Alex Deucher
[not found] ` <1498235706-31111-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-06-23 16:43 ` Christian König
2017-06-23 17:05 ` Alex Deucher
2017-06-26 13:29 ` Christian König
2017-06-28 17:54 ` Mark Brown
2017-06-23 16:35 ` [PATCH 2/8] ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver Alex Deucher
2017-06-28 19:23 ` Applied "ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver" to the asoc tree Mark Brown
2017-06-23 16:35 ` [PATCH 4/8] ASoC: AMD: added condition checks for CZ specific code Alex Deucher
2017-06-28 18:05 ` Mark Brown
2017-06-29 12:58 ` Mukunda, Vijendar
2017-06-30 10:16 ` Mark Brown
2017-06-23 16:35 ` [PATCH 6/8] ASoC: AMD: Buffer related changes for Stoney Alex Deucher
2017-06-23 16:35 ` [PATCH 7/8] drm/amd/amdgpu: Disable ACP Power Gating for Stoney platform Alex Deucher
2017-06-23 16:35 ` [PATCH 8/8] ASoC: AMD: Add machine driver for cz rt5650 Alex Deucher
2017-06-23 20:01 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628180235.2dscruiilz37gtr3@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Vijendar.Mukunda@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=rajeevkumar.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.