From: Daniel Scheller <d.scheller.oss@gmail.com>
To: Ralph Metzler <rjkm@metzlerbros.de>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
mchehab@s-opensource.com, jasmin@anw.at, d_spingler@gmx.de
Subject: Re: [PATCH 1/4] [media] dvb-frontends: MaxLinear MxL5xx DVB-S/S2 tuner-demodulator driver
Date: Mon, 10 Jul 2017 17:40:31 +0200 [thread overview]
Message-ID: <20170710174031.608b35b5@audiostation.wuest.de> (raw)
In-Reply-To: <22883.15775.467965.425483@morden.metzler>
Am Mon, 10 Jul 2017 10:41:03 +0200
schrieb Ralph Metzler <rjkm@metzlerbros.de>:
> Daniel Scheller writes:
> > From: Daniel Scheller <d.scheller@gmx.net>
> >
> > This adds the frontend driver for the MaxLinear MxL5xx family of
> > tuner- demodulators, as used on Digital Devices MaxS4/8
> > four/eight-tuner cards.
> >
> > The driver was picked from the dddvb vendor driver package and -
> > judging solely from the diff - has undergone a 100% rework:
> >
> > - Silly #define's used to pass multiple values to functions were
> > expanded. This resulted in macro/register names not being usable
> > anymore for such occurences, but makes the code WAY more read-,
> > understand- and maintainable.
>
> OK, but why did you also replace all kinds of register value defines
> with numerical values? This makes the driver much less comprehensible.
I actually tried to put named identifiers back in as I don't feel very
comfortable with just plain hex numbers, there aren't even that many
registers that get accessed. But as I tried to do (based on the
original _regs.h), I quickly found out that one register can belong to
many identifiers, with the only difference being the bitshift and
bitcount, so without knowing the correct names this ends up in lottery
style, which isn't good either. If you have some documentation on this
and can provide that, we can put names back in place of course.
Best regards,
Daniel Scheller
--
https://github.com/herrnst
next prev parent reply other threads:[~2017-07-10 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 19:42 [PATCH 0/4] MxL5xx demodulator-tuner driver, DD MaxS8 support Daniel Scheller
2017-07-09 19:42 ` [PATCH 1/4] [media] dvb-frontends: MaxLinear MxL5xx DVB-S/S2 tuner-demodulator driver Daniel Scheller
2017-07-10 8:41 ` Ralph Metzler
2017-07-10 15:40 ` Daniel Scheller [this message]
2017-07-09 19:42 ` [PATCH 2/4] [media] ddbridge: support MaxLinear MXL5xx based cards (MaxS4/8) Daniel Scheller
2017-07-09 19:42 ` [PATCH 3/4] [media] ddbridge: fix buffer overflow in max_set_input_unlocked() Daniel Scheller
2017-07-10 8:12 ` Ralph Metzler
2017-07-10 15:43 ` Daniel Scheller
2017-07-09 19:42 ` [PATCH 4/4] [media] MAINTAINERS: add entry for mxl5xx Daniel Scheller
2017-08-20 11:15 ` [PATCH 0/4] MxL5xx demodulator-tuner driver, DD MaxS8 support Daniel Scheller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710174031.608b35b5@audiostation.wuest.de \
--to=d.scheller.oss@gmail.com \
--cc=d_spingler@gmx.de \
--cc=jasmin@anw.at \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
--cc=rjkm@metzlerbros.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.