From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 00/12] drm/atomic: Make drm_atomic_helper_swap_state waiting interruptible.
Date: Tue, 11 Jul 2017 16:33:02 +0200 [thread overview]
Message-ID: <20170711143314.2148-1-maarten.lankhorst@linux.intel.com> (raw)
drm_atomic_helper_swap_state could previously never fail, in order to still
continue it would set a limit of 10s on waiting for previous updates to complete,
then it moved forward. This can be very bad when ignoring previous updates,
because the hw state and sw state may get out of sync when for example a modeset
is ignored.
By converting the swap_state to interruptible and handling the error in each driver,
we fix this issue because if a update takes forever it can be aborted through signals.
Changes since first version:
- Split out driver conversions.
- Fix nouveau error handling first.
Maarten Lankhorst (12):
drm/nouveau: Fix error handling in nv50_disp_atomic_commit
drm/atomic: Change drm_atomic_helper_swap_state to return an error.
drm/nouveau: Handle drm_atomic_helper_swap_state failure
drm/atmel-hlcdc: Handle drm_atomic_helper_swap_state failure
drm/i915: Handle drm_atomic_helper_swap_state failure
drm/mediatek: Handle drm_atomic_helper_swap_state failure
drm/msm: Handle drm_atomic_helper_swap_state failure
drm/tegra: Handle drm_atomic_helper_swap_state failure
drm/tilcdc: Handle drm_atomic_helper_swap_state failure
drm/vc4: Handle drm_atomic_helper_swap_state failure
drm/atomic: Add __must_check to drm_atomic_helper_swap_state.
drm/atomic: Allow drm_atomic_helper_swap_state to fail
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 13 ++++++-----
drivers/gpu/drm/drm_atomic_helper.c | 35 +++++++++++++++++-----------
drivers/gpu/drm/i915/intel_display.c | 10 +++++++-
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 +++++-
drivers/gpu/drm/msm/msm_atomic.c | 16 ++++++-------
drivers/gpu/drm/nouveau/nv50_display.c | 12 +++++++---
drivers/gpu/drm/tegra/drm.c | 7 +++++-
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 ++++-
drivers/gpu/drm/vc4/vc4_kms.c | 2 +-
include/drm/drm_atomic_helper.h | 4 ++--
10 files changed, 75 insertions(+), 37 deletions(-)
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2017-07-11 14:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 14:33 Maarten Lankhorst [this message]
2017-07-11 14:33 ` [PATCH v2 01/12] drm/nouveau: Fix error handling in nv50_disp_atomic_commit Maarten Lankhorst
2017-07-14 14:28 ` [Intel-gfx] " Daniel Vetter
2017-07-11 14:33 ` [PATCH v2 02/12] drm/atomic: Change drm_atomic_helper_swap_state to return an error Maarten Lankhorst
2017-07-11 14:33 ` Maarten Lankhorst
2017-07-14 14:30 ` [Intel-gfx] " Daniel Vetter
2017-07-14 14:55 ` Sean Paul
2017-07-11 14:33 ` [PATCH v2 04/12] drm/atmel-hlcdc: Handle drm_atomic_helper_swap_state failure Maarten Lankhorst
2017-07-11 14:33 ` [PATCH v2 05/12] drm/i915: " Maarten Lankhorst
2017-07-11 14:33 ` [PATCH v2 06/12] drm/mediatek: " Maarten Lankhorst
2017-07-11 14:33 ` Maarten Lankhorst
2017-07-12 10:00 ` Philipp Zabel
2017-07-12 10:00 ` Philipp Zabel
[not found] ` <20170711143314.2148-1-maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-11 14:33 ` [PATCH v2 03/12] drm/nouveau: " Maarten Lankhorst
2017-07-11 14:33 ` [PATCH v2 07/12] drm/msm: " Maarten Lankhorst
2017-07-14 15:02 ` [Intel-gfx] " Daniel Vetter
2017-07-11 14:33 ` [PATCH v2 08/12] drm/tegra: " Maarten Lankhorst
[not found] ` <20170711143314.2148-9-maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-14 15:03 ` [Intel-gfx] " Daniel Vetter
2017-07-11 14:33 ` [PATCH v2 09/12] drm/tilcdc: " Maarten Lankhorst
2017-07-27 7:49 ` Jyri Sarha
2017-07-27 10:25 ` Maarten Lankhorst
2017-07-11 14:33 ` [PATCH v2 10/12] drm/vc4: " Maarten Lankhorst
2017-07-14 15:04 ` [Intel-gfx] " Daniel Vetter
2017-07-11 14:33 ` [PATCH v2 11/12] drm/atomic: Add __must_check to drm_atomic_helper_swap_state Maarten Lankhorst
2017-07-14 15:05 ` Daniel Vetter
2017-07-11 14:33 ` [PATCH v2 12/12] drm/atomic: Allow drm_atomic_helper_swap_state to fail Maarten Lankhorst
2017-07-14 15:06 ` [Intel-gfx] " Daniel Vetter
2017-07-11 15:11 ` ✗ Fi.CI.BAT: warning for drm/atomic: Make drm_atomic_helper_swap_state waiting interruptible Patchwork
2017-07-14 15:01 ` [PATCH v2 00/12] " Sean Paul
2017-07-19 10:10 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711143314.2148-1-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.