From: Sean Paul <seanpaul@chromium.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Shawn Guo <shawnguo@kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/zte: Use gem_free_object_unlocked
Date: Mon, 17 Jul 2017 16:37:54 -0400 [thread overview]
Message-ID: <20170717203754.7cvvstnhmon3tt64@art_vandelay> (raw)
In-Reply-To: <20170717151045.4188-3-daniel.vetter@ffwll.ch>
On Mon, Jul 17, 2017 at 05:10:45PM +0200, Daniel Vetter wrote:
> CMA helpers are struct_mutex free, and so is the mxsfb itself. And
mxsfb copypasta
otherwise
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> that's the only valid reason for using gem_free_object. Please read
> the kerneldoc for this stuff :-)
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> ---
> drivers/gpu/drm/zte/zx_drm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index fe1aa5315e19..c983cdfa1e34 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -59,7 +59,7 @@ static struct drm_driver zx_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME |
> DRIVER_ATOMIC,
> .lastclose = zx_drm_lastclose,
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .dumb_create = drm_gem_cma_dumb_create,
> .dumb_map_offset = drm_gem_cma_dumb_map_offset,
> --
> 2.13.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-17 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:10 [PATCH 1/3] drm/mxsfb: Use gem_free_object_unlocked Daniel Vetter
2017-07-17 15:10 ` [PATCH 2/3] drm/pl111: " Daniel Vetter
2017-07-17 15:10 ` [PATCH 3/3] drm/zte: " Daniel Vetter
2017-07-17 20:37 ` Sean Paul [this message]
2017-07-17 18:01 ` [PATCH 1/3] drm/mxsfb: " Eric Anholt
2017-07-18 6:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717203754.7cvvstnhmon3tt64@art_vandelay \
--to=seanpaul@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.