All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: david@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] target/s390x ilen via unwinding
Date: Mon, 24 Jul 2017 19:36:07 -0700	[thread overview]
Message-ID: <20170725023611.9169-1-rth@twiddle.net> (raw)

David Hildenbrand recently posted a series of patches correcting
various mistakes in the computation of ILEN for various instructions
in the respective helpers.

I think a better approach is to include ilen in the set of unwind
data for each insn.  In this way we can fix these sorts of errors
automatically.  At the same time begin to wean ourselves away from
ILEN_AUTO, which requires re-reading from the instruction stream.

Almost certainly 2.11 material.  Thoughts?


r~


Richard Henderson (4):
  target/s390x: Add ilen to unwind data
  target/s390x: Use ILEN_UNWIND in trivial cases
  target/s390x: Use unwind info in STSI
  target/s390x: Use ilen from unwind in tlb_fill

 target/s390x/cpu.h         |  9 ++++++---
 target/s390x/helper.c      | 14 ++++++++------
 target/s390x/mem_helper.c  | 39 +++++++++++++++++++++++++--------------
 target/s390x/misc_helper.c | 10 +++++++---
 target/s390x/translate.c   | 10 ++++++++--
 5 files changed, 54 insertions(+), 28 deletions(-)

-- 
2.13.3

             reply	other threads:[~2017-07-25  2:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25  2:36 Richard Henderson [this message]
2017-07-25  2:36 ` [Qemu-devel] [PATCH 1/4] target/s390x: Add ilen to unwind data Richard Henderson
2017-07-25  7:15   ` David Hildenbrand
2017-07-25  2:36 ` [Qemu-devel] [PATCH 2/4] target/s390x: Use ILEN_UNWIND in trivial cases Richard Henderson
2017-07-25  7:18   ` David Hildenbrand
2017-07-25  2:36 ` [Qemu-devel] [PATCH 3/4] target/s390x: Use unwind info in STSI Richard Henderson
2017-07-25  7:19   ` David Hildenbrand
2017-07-25  2:36 ` [Qemu-devel] [PATCH 4/4] target/s390x: Use ilen from unwind in tlb_fill Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725023611.9169-1-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.