All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Liljestrand <liljestrandh@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: "kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	"Reshetova, Elena" <elena.reshetova@intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [kernel-hardening] Re: [RFC PATCH 4/5] x86: MPXK base
Date: Tue, 25 Jul 2017 10:57:34 +0300	[thread overview]
Message-ID: <20170725075734.3vnyt4awlftm3c4k@ishxps> (raw)
In-Reply-To: <CAGXu5jLk-LFGg4RW6_qGBXjgpvxySUh71Xod_C=JuqK4XmBAzw@mail.gmail.com>

On Mon, Jul 24, 2017 at 07:48:03PM -0700, Kees Cook wrote:
>On Mon, Jul 24, 2017 at 6:38 AM, Hans Liljestrand
><liljestrandh@gmail.com> wrote:
>> Enable and add needed support functionality for ring 0 MPX. MPXK is
>> enabled in init/main.c by setting the BNDCFGS MSR registers. This also
>> includes the mpxk_load_bounds implementation and error handling code for
>> MPX errors, i.e. bound violations.
>
>Maybe I missed it somewhere else, but this seems like there is no CPU
>feature flag testing. I'd expect runtime alternatives or something to
>disable this dynamically if the CPU didn't support it.

No, it seems I missed it :)

(although I am sure I had a test in there at some point)

Thanks for catching this!

-hans

>
>-Kees
>
>-- 
>Kees Cook
>Pixel Security

  reply	other threads:[~2017-07-25  7:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 13:38 [kernel-hardening] [RFC PATCH 0/5] MPXK: Intel MPX for in-kernel use Hans Liljestrand
2017-07-24 13:38 ` [kernel-hardening] [RFC PATCH 1/5] x86: add CONFIG_X86_INTEL_MPX_KERNEL to Kconfig Hans Liljestrand
2017-07-25  2:51   ` [kernel-hardening] " Kees Cook
2017-07-25  7:10     ` Hans Liljestrand
2017-07-24 13:38 ` [kernel-hardening] [RFC PATCH 2/5] gcc-plugins: adds MPXK gcc plugin Hans Liljestrand
2017-07-25  2:40   ` [kernel-hardening] " Kees Cook
2017-07-25  7:16     ` Hans Liljestrand
2017-07-24 13:38 ` [kernel-hardening] [RFC PATCH 3/5] x86: add mpxk-wrappers Hans Liljestrand
2017-07-25  2:45   ` [kernel-hardening] " Kees Cook
2017-07-25  7:52     ` Hans Liljestrand
2017-07-25 18:22       ` Kees Cook
2017-07-26  9:15         ` Hans Liljestrand
2017-07-24 13:38 ` [kernel-hardening] [RFC PATCH 4/5] x86: MPXK base Hans Liljestrand
2017-07-25  2:48   ` [kernel-hardening] " Kees Cook
2017-07-25  7:57     ` Hans Liljestrand [this message]
2017-07-24 13:38 ` [kernel-hardening] [RFC PATCH 5/5] lkdtm: Add kernel MPX testing Hans Liljestrand
2017-07-25  3:11   ` [kernel-hardening] " Kees Cook
2017-07-25  8:17     ` Hans Liljestrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725075734.3vnyt4awlftm3c4k@ishxps \
    --to=liljestrandh@gmail.com \
    --cc=dave.hansen@intel.com \
    --cc=elena.reshetova@intel.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.