From: bfields@fieldses.org (J. Bruce Fields)
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 08/11] network.c: removed some warnings
Date: Tue, 25 Jul 2017 16:52:14 -0400 [thread overview]
Message-ID: <20170725205214.GB15694@fieldses.org> (raw)
In-Reply-To: <20170721163806.15803-9-steved@redhat.com>
On Fri, Jul 21, 2017 at 12:38:03PM -0400, Steve Dickson wrote:
> network.c:1234:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> network.c:1382:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> network.c:1477:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> network.c:1508:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> network.c:1574:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> utils/mount/network.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/utils/mount/network.c b/utils/mount/network.c
> index 281e935..e56a8d4 100644
> --- a/utils/mount/network.c
> +++ b/utils/mount/network.c
> @@ -1235,6 +1235,7 @@ nfs_nfs_program(struct mount_options *options, unsigned long *program)
> *program = tmp;
> return 1;
> }
> + /* FALLTHRU */
> case PO_BAD_VALUE:
> nfs_error(_("%s: invalid value for 'nfsprog=' option"),
> progname);
> @@ -1383,6 +1384,7 @@ nfs_nfs_port(struct mount_options *options, unsigned long *port)
> *port = tmp;
> return 1;
> }
> + /* FALLTHRU */
> case PO_BAD_VALUE:
> nfs_error(_("%s: invalid value for 'port=' option"),
> progname);
> @@ -1478,6 +1480,7 @@ nfs_mount_program(struct mount_options *options, unsigned long *program)
> *program = tmp;
> return 1;
> }
> + /* FALLTHRU */
Indentation nit.
--b.
> case PO_BAD_VALUE:
> nfs_error(_("%s: invalid value for 'mountprog=' option"),
> progname);
> @@ -1509,6 +1512,7 @@ nfs_mount_version(struct mount_options *options, unsigned long *version)
> *version = tmp;
> return 1;
> }
> + /* FALLTHRU */
> case PO_BAD_VALUE:
> nfs_error(_("%s: invalid value for 'mountvers=' option"),
> progname);
> @@ -1575,6 +1579,7 @@ nfs_mount_port(struct mount_options *options, unsigned long *port)
> *port = tmp;
> return 1;
> }
> + /* FALLTHRU */
> case PO_BAD_VALUE:
> nfs_error(_("%s: invalid value for 'mountport=' option"),
> progname);
> --
> 2.13.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-25 20:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 16:37 [PATCH 00/11 V2] Removed a bunch random warnings Steve Dickson
2017-07-21 16:37 ` [PATCH 01/11] rpcdebug.c: remove a warning Steve Dickson
2017-07-21 16:37 ` [PATCH 02/11] present_address: Fixed error path Steve Dickson
2017-07-21 16:37 ` [PATCH 03/11] atomicio: removed a warning Steve Dickson
2017-07-25 20:51 ` J. Bruce Fields
2017-07-21 16:37 ` [PATCH 04/11] cache.c: removed a couple warning Steve Dickson
2017-07-21 16:38 ` [PATCH 05/11] nfsd.c: removed a few warnings Steve Dickson
2017-07-21 16:38 ` [PATCH 06/11] bldev_read_serial: removed a couple warnings Steve Dickson
2017-07-21 16:38 ` [PATCH 07/11] device-discovery.c: removed a warning Steve Dickson
2017-07-21 16:38 ` [PATCH 08/11] network.c: removed some warnings Steve Dickson
2017-07-25 20:52 ` J. Bruce Fields [this message]
2017-07-21 16:38 ` [PATCH 09/11] nfsmount: remove a warning Steve Dickson
2017-07-21 16:38 ` [PATCH 10/11] nfs4mount: removed " Steve Dickson
2017-07-21 16:38 ` [PATCH 11/11] nfsdcltrack.c: remove " Steve Dickson
2017-07-25 20:53 ` [PATCH 00/11 V2] Removed a bunch random warnings J. Bruce Fields
2017-07-26 15:17 ` Steve Dickson
2017-07-26 15:32 ` Steve Dickson
-- strict thread matches above, loose matches on Subject: below --
2017-07-19 20:53 [PATCH 00/11] " Steve Dickson
2017-07-19 20:53 ` [PATCH 08/11] network.c: removed some warnings Steve Dickson
2017-07-20 18:37 ` J. Bruce Fields
2017-07-21 16:29 ` Steve Dickson
2017-07-21 18:30 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725205214.GB15694@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.