Re: [PATCH v1 2/3] ASoC: codecs: msm8916-analog: support jack detection

From: Mark Brown <broonie@kernel.org>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Patrick Lai <plai@codeaurora.org>,
	Banajit Goswami <bgoswami@codeaurora.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	kernel@savoirfairelinux.com
Subject: Re: [PATCH v1 2/3] ASoC: codecs: msm8916-analog: support jack detection
Date: Wed, 26 Jul 2017 17:21:49 +0100	[thread overview]
Message-ID: <20170726162149.g72j5fdgtyyfrqs2@sirena.org.uk> (raw)
In-Reply-To: <20170725175126.26578-3-damien.riegel@savoirfairelinux.com>

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

On Tue, Jul 25, 2017 at 01:51:25PM -0400, Damien Riegel wrote:

> +	for (i = 0; i < ARRAY_SIZE(jack_detect_irqs); i++) {
> +		int irq;
> +
> +		irq = platform_get_irq_byname(pdev, jack_detect_irqs[i].name);
> +		if (irq < 0) {
> +			dev_warn(dev, "failed to get irq '%s', jack insertion detection disabled\n",
> +				 jack_detect_irqs[i].name);
> +			break;
> +		}
> +
> +		ret = devm_request_threaded_irq(dev, irq, NULL,

Don't put the loop in when there's only one IRQ, wait till it's needed.
This is an unusual pattern and it's not clear that just bombing out of
the loop with interrupts half requested is a good idea.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]