All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guneshwor Singh <guneshwor.o.singh@intel.com>
To: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Vinod Koul <vinod.koul@intel.com>,
	Guneshwor Singh <guneshwor.o.singh@intel.com>,
	Patches Audio <patches.audio@intel.com>
Subject: [PATCH 1/4] ASoC: Intel: Skylake: Reset the controller in probe
Date: Fri, 28 Jul 2017 16:12:13 +0530	[thread overview]
Message-ID: <20170728104216.26859-1-guneshwor.o.singh@intel.com> (raw)

Controller can be in reset state by default. Capability structure
traversal requires the controller to be out of reset else it
results in broken capability parsing. Hence make sure that controller is
out of reset before parsing capabilities by doing a full reset.

Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
---
 sound/soc/intel/skylake/skl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index 334917ee41cf..a56dfde3928c 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -702,6 +702,8 @@ static int skl_first_init(struct hdac_ext_bus *ebus)
 		return -ENXIO;
 	}
 
+	skl_init_chip(bus, true);
+
 	snd_hdac_bus_parse_capabilities(bus);
 
 	if (skl_acquire_irq(ebus, 0) < 0)
-- 
2.13.0

             reply	other threads:[~2017-07-28 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 10:42 Guneshwor Singh [this message]
2017-07-28 10:42 ` [PATCH 2/4] ASoC: Intel: bxtn: Remove code loader reference in cleanup Guneshwor Singh
2017-08-01 14:16   ` Applied "ASoC: Intel: bxtn: Remove code loader reference in cleanup" to the asoc tree Mark Brown
2017-07-28 10:42 ` [PATCH 3/4] ASoC: Intel: Skylake: Remove return check for skl_codec_create() Guneshwor Singh
2017-08-01 14:16   ` Applied "ASoC: Intel: Skylake: Remove return check for skl_codec_create()" to the asoc tree Mark Brown
2017-07-28 10:42 ` [PATCH 4/4] ASoC: Intel: Skylake: Fix potential null pointer dereference Guneshwor Singh
2017-08-01 14:16   ` Applied "ASoC: Intel: Skylake: Fix potential null pointer dereference" to the asoc tree Mark Brown
2017-07-29  4:35 ` [PATCH 1/4] ASoC: Intel: Skylake: Reset the controller in probe Vinod Koul
2017-08-01 14:16 ` Applied "ASoC: Intel: Skylake: Reset the controller in probe" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728104216.26859-1-guneshwor.o.singh@intel.com \
    --to=guneshwor.o.singh@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.