All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>, Arnd Bergmann <arnd@arndb.de>,
	Paul Burton <paul.burton@imgtec.com>,
	Rich Felker <dalias@libc.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Richard Henderson <rth@twiddle.net>,
	Tanmay Inamdar <tinamdar@apm.com>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Chris Metcalf <cmetcalf@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>,
	Matthew Minter <matt@masarand.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: [RFT PATCH 0/9] PCI: Remove pci_fixup_irqs()
Date: Mon, 31 Jul 2017 17:37:48 +0100	[thread overview]
Message-ID: <20170731163757.22629-1-lorenzo.pieralisi@arm.com> (raw)

The pci_fixup_irqs() function allocates IRQs for all PCI devices present
in a system; those PCI devices possibly belong to different PCI bus trees
(and possibly rooted at different host bridges) and may well be enabled
(ie probed and bound to a driver) by the time pci_fixup_irqs() is called
when probing a given host bridge driver.

Furthermore, current kernel code relying on pci_fixup_irqs() to
assign legacy PCI IRQs to devices does not work at all for
hotplugged devices in that the code carrying out the IRQ fixup
is called at host bridge driver probe time, which just cannot take
into account devices hotplugged after system has booted.

The introduction of map/swizzle functions hook in struct pci_host_bridge
allows to define per-bridge map/swizzle functions, that can be used at
device probe time in PCI core code to allocate IRQs for a given device
(through pci_assign_irq()).

This series converts all arches still relying on pci_fixup_irqs() to
the new pci_scan_root_bus_bridge() API and consequently remove
pci_fixup_irqs() from the kernel in that it is not used anymore.

Compile tested only, I do not have the necessary hardware.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git pci/pci-fixup-irqs-removal

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Rich Felker <dalias@libc.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Tanmay Inamdar <tinamdar@apm.com>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Matthew Minter <matt@masarand.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>

Lorenzo Pieralisi (7):
  sh/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ mapping
    hooks
  alpha/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ
    mapping hooks
  m68k/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ
    mapping hooks
  MIPS/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ
    mapping hooks
  tile/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ
    mapping hooks
  unicore32/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ
    mapping hooks
  sparc/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ
    mapping hooks

Matthew Minter (2):
  sh/PCI: Remove __init optimisations from IRQ mapping functions/data
  PCI: Remove pci_fixup_irqs() function

 arch/alpha/kernel/pci.c                 | 27 ++++++++++++++++------
 arch/alpha/kernel/sys_nautilus.c        | 31 +++++++++++++++++++++----
 arch/m68k/coldfire/pci.c                | 36 +++++++++++++++++++++++++----
 arch/mips/pci/pci-legacy.c              | 24 +++++++++++++------
 arch/sh/drivers/pci/fixups-cayman.c     |  2 +-
 arch/sh/drivers/pci/fixups-dreamcast.c  |  2 +-
 arch/sh/drivers/pci/fixups-r7780rp.c    |  2 +-
 arch/sh/drivers/pci/fixups-rts7751r2d.c |  6 ++---
 arch/sh/drivers/pci/fixups-sdk7780.c    |  4 ++--
 arch/sh/drivers/pci/fixups-se7751.c     |  2 +-
 arch/sh/drivers/pci/fixups-sh03.c       |  2 +-
 arch/sh/drivers/pci/fixups-snapgear.c   |  2 +-
 arch/sh/drivers/pci/fixups-titan.c      |  4 ++--
 arch/sh/drivers/pci/pci.c               | 41 ++++++++++++++++++++-------------
 arch/sh/drivers/pci/pcie-sh7786.c       |  2 +-
 arch/sparc/kernel/leon_pci.c            | 24 ++++++++++++++-----
 arch/tile/kernel/pci.c                  | 21 +++++++++++++----
 arch/tile/kernel/pci_gx.c               | 21 +++++++++++++----
 arch/unicore32/kernel/pci.c             | 35 ++++++++++++++++++++++++----
 drivers/pci/setup-irq.c                 | 24 -------------------
 include/linux/pci.h                     |  2 --
 21 files changed, 216 insertions(+), 98 deletions(-)

-- 
2.10.0

             reply	other threads:[~2017-07-31 16:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 16:37 Lorenzo Pieralisi [this message]
2017-07-31 16:37 ` [RFT PATCH 1/9] sh/PCI: Remove __init optimisations from IRQ mapping functions/data Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 2/9] sh/PCI: Replace pci_fixup_irqs() call with PCI host bridge IRQ mapping hooks Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 3/9] alpha/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 4/9] m68k/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 5/9] MIPS/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 6/9] tile/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 7/9] unicore32/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 8/9] sparc/PCI: " Lorenzo Pieralisi
2017-07-31 16:37 ` [RFT PATCH 9/9] PCI: Remove pci_fixup_irqs() function Lorenzo Pieralisi
2017-08-03 21:35 ` [RFT PATCH 0/9] PCI: Remove pci_fixup_irqs() Bjorn Helgaas
2017-08-04 15:08   ` Lorenzo Pieralisi
2017-08-10 17:52 ` [PATCH] PCI: Inline and remove pcibios_update_irq() Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170731163757.22629-1-lorenzo.pieralisi@arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=cmetcalf@mellanox.com \
    --cc=dalias@libc.org \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matt@masarand.com \
    --cc=paul.burton@imgtec.com \
    --cc=ralf@linux-mips.org \
    --cc=rth@twiddle.net \
    --cc=tinamdar@apm.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.