All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Sean Wang <sean.wang@mediatek.com>
Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org, Muciri Gatimu <muciri@openmesh.com>,
	Shashidhar Lakkavalli <shashidhar.lakkavalli@openmesh.com>,
	John Crispin <john@phrozen.org>
Subject: [PATCH 1/4] net-next: dsa: move struct dsa_device_ops to the global header file
Date: Wed,  9 Aug 2017 14:41:16 +0200	[thread overview]
Message-ID: <20170809124119.24320-2-john@phrozen.org> (raw)
In-Reply-To: <20170809124119.24320-1-john@phrozen.org>

We need to access this struct from within the flow_dissector to fix
dissection for packets coming in on DSA devices.

Signed-off-by: Muciri Gatimu <muciri@openmesh.com>
Signed-off-by: Shashidhar Lakkavalli <shashidhar.lakkavalli@openmesh.com>
Signed-off-by: John Crispin <john@phrozen.org>
---
 include/net/dsa.h  | 7 +++++++
 net/dsa/dsa_priv.h | 7 -------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/net/dsa.h b/include/net/dsa.h
index a4f66dbb4b7c..65d7804c6f69 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -101,6 +101,13 @@ struct dsa_platform_data {
 
 struct packet_type;
 
+struct dsa_device_ops {
+	struct sk_buff *(*xmit)(struct sk_buff *skb, struct net_device *dev);
+	struct sk_buff *(*rcv)(struct sk_buff *skb, struct net_device *dev,
+			       struct packet_type *pt,
+			       struct net_device *orig_dev);
+};
+
 struct dsa_switch_tree {
 	struct list_head	list;
 
diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h
index 68c63d4b989c..9fff7f4c8689 100644
--- a/net/dsa/dsa_priv.h
+++ b/net/dsa/dsa_priv.h
@@ -65,13 +65,6 @@ struct dsa_notifier_vlan_info {
 	int port;
 };
 
-struct dsa_device_ops {
-	struct sk_buff *(*xmit)(struct sk_buff *skb, struct net_device *dev);
-	struct sk_buff *(*rcv)(struct sk_buff *skb, struct net_device *dev,
-			       struct packet_type *pt,
-			       struct net_device *orig_dev);
-};
-
 struct dsa_slave_priv {
 	/* Copy of dp->ds->dst->tag_ops->xmit for faster access in hot path */
 	struct sk_buff *	(*xmit)(struct sk_buff *skb,
-- 
2.11.0

  reply	other threads:[~2017-08-09 12:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 12:41 [PATCH 0/4] net-next: dsa: fix flow dissection John Crispin
2017-08-09 12:41 ` John Crispin
2017-08-09 12:41 ` John Crispin [this message]
2017-08-09 13:45   ` [PATCH 1/4] net-next: dsa: move struct dsa_device_ops to the global header file Andrew Lunn
2017-08-09 13:45     ` Andrew Lunn
2017-08-09 12:41 ` [PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops John Crispin
2017-08-09 12:41   ` John Crispin
2017-08-09 13:51   ` Andrew Lunn
2017-08-09 13:51     ` Andrew Lunn
2017-08-09 12:41 ` [PATCH 3/4] net-next: tag_mtk: add flow_dissect callback to the ops struct John Crispin
2017-08-09 13:54   ` Andrew Lunn
2017-08-09 12:41 ` [PATCH 4/4] net-next: dsa: fix flow dissection John Crispin
2017-08-09 12:41   ` John Crispin
2017-08-09 13:55   ` Andrew Lunn
2017-08-09 13:55     ` Andrew Lunn
2017-08-09 15:07 ` [PATCH 0/4] " Vivien Didelot
2017-08-09 15:07   ` Vivien Didelot
2017-08-10  5:52 ` David Miller
2017-08-10  6:42   ` Eric Dumazet
2017-08-10  7:40     ` John Crispin
2017-08-10  8:10     ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809124119.24320-2-john@phrozen.org \
    --to=john@phrozen.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=muciri@openmesh.com \
    --cc=netdev@vger.kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=shashidhar.lakkavalli@openmesh.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.