From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: fenglinw@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
collinsd@codeaurora.org, aghayal@codeaurora.org,
wruan@codeaurora.org, kgunda@codeaurora.org
Subject: Re: [PATCH V2 2/2] pinctrl: qcom: spmi-gpio: Add dtest route for digital input
Date: Fri, 11 Aug 2017 09:27:22 -0700 [thread overview]
Message-ID: <20170811162722.GF2016@tuxbook> (raw)
In-Reply-To: <20170719063136.5300-3-fenglinw@codeaurora.org>
On Tue 18 Jul 23:30 PDT 2017, fenglinw@codeaurora.org wrote:
[..]
> @@ -528,6 +547,20 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
> if (ret < 0)
> return ret;
>
> + if (pad->dtest_buffer == 0) {
> + val = 0;
> + } else {
> + if (pad->lv_mv_type) {
> + val = pad->dtest_buffer - 1;
> + val |= PMIC_GPIO_LV_MV_DIG_IN_DTEST_EN;
> + } else {
> + val = 1 << (pad->dtest_buffer - 1);
val = BIT(pad->dtest_buffer - 1);
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
prev parent reply other threads:[~2017-08-11 16:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 6:30 [PATCH V2 0/2] Add LV/MV subtypes support for QCOM PMIC GPIOs fenglinw
2017-07-19 6:30 ` [PATCH V2 1/2] pinctrl: qcom: spmi-gpio: Add support for GPIO LV/MV subtype fenglinw
[not found] ` <20170719063136.5300-2-fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-24 19:07 ` Rob Herring
2017-07-24 19:07 ` Rob Herring
2017-08-11 16:10 ` Bjorn Andersson
2017-07-19 6:30 ` [PATCH V2 2/2] pinctrl: qcom: spmi-gpio: Add dtest route for digital input fenglinw
[not found] ` <20170719063136.5300-3-fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-24 16:09 ` Rob Herring
2017-07-24 16:09 ` Rob Herring
2017-08-11 16:27 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811162722.GF2016@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=aghayal@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=fenglinw@codeaurora.org \
--cc=kgunda@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wruan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.