All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 11/14] ASoC: Intel: bytcr_rt5640: simplify MCLK quirk tests
Date: Tue, 22 Aug 2017 15:32:36 -0500	[thread overview]
Message-ID: <20170822203239.19891-12-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20170822203239.19891-1-pierre-louis.bossart@linux.intel.com>

remove redundant tests to check MCLK (align with other
machine drivers)

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/bytcr_rt5640.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 15b1e29..7cee09d 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -178,7 +178,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
 	}
 
 	if (SND_SOC_DAPM_EVENT_ON(event)) {
-		if ((byt_rt5640_quirk & BYT_RT5640_MCLK_EN) && priv->mclk) {
+		if (priv->mclk) {
 			ret = clk_prepare_enable(priv->mclk);
 			if (ret < 0) {
 				dev_err(card->dev,
@@ -199,7 +199,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
 					     48000 * 512,
 					     SND_SOC_CLOCK_IN);
 		if (!ret) {
-			if ((byt_rt5640_quirk & BYT_RT5640_MCLK_EN) && priv->mclk)
+			if (priv->mclk)
 				clk_disable_unprepare(priv->mclk);
 		}
 	}
@@ -549,7 +549,7 @@ static int byt_rt5640_init(struct snd_soc_pcm_runtime *runtime)
 	snd_soc_dapm_ignore_suspend(&card->dapm, "Headphone");
 	snd_soc_dapm_ignore_suspend(&card->dapm, "Speaker");
 
-	if ((byt_rt5640_quirk & BYT_RT5640_MCLK_EN) && priv->mclk) {
+	if (priv->mclk) {
 		/*
 		 * The firmware might enable the clock at
 		 * boot (this information may or may not
-- 
2.9.3

  parent reply	other threads:[~2017-08-22 20:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 20:32 [PATCH 00/14] BYT/CHT codec/machine drivers update Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 01/14] ASoC: Intel: boards: use devm_clk_get() unconditionally Pierre-Louis Bossart
2017-08-23 14:22   ` Andy Shevchenko
2017-08-22 20:32 ` [PATCH 02/14] ASoC: intel: cht_bsw_max98090: add support for clock framework Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 03/14] ASoC: Intel: cht_bsw_max98090: Fix I2S config + unused code Pierre-Louis Bossart
2017-09-19 13:45   ` Applied "ASoC: Intel: cht_bsw_max98090: Fix I2S config + unused code" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 04/14] ASoc: cht_bsw_max98090_ti: Fix jack initialization Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 05/14] ASoC: ts3a227e: add acpi table Pierre-Louis Bossart
2017-08-23 11:19   ` Mark Brown
2017-08-22 20:32 ` [PATCH 06/14] ASoC: Intel: atom: add support for Baytrail Chromebooks Pierre-Louis Bossart
2017-09-19 13:45   ` Applied "ASoC: Intel: atom: use cht_bsw_max98090 for Baytrail Chromebooks" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 07/14] ASoC: Intel: bytcr-rt5651: fix capture routes Pierre-Louis Bossart
2017-09-19 13:46   ` Applied "ASoC: Intel: bytcr-rt5651: fix capture routes" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 08/14] ASoC: Intel: bytcr_rt5651: add MCLK support Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 09/14] ASoC: Intel: bytcr_rt5651: filter codec name Pierre-Louis Bossart
2017-08-22 20:32 ` [PATCH 10/14] ASoC: codecs: rt5645: add quirks for Asus T100HA Pierre-Louis Bossart
2017-08-23 11:24   ` Applied "ASoC: codecs: rt5645: add quirks for Asus T100HA" to the asoc tree Mark Brown
2017-08-22 20:32 ` Pierre-Louis Bossart [this message]
2017-09-19 13:45   ` Applied "ASoC: Intel: bytcr_rt5640: simplify MCLK quirk tests" " Mark Brown
2017-08-22 20:32 ` [PATCH 12/14] ASoC: codecs: rt5670: add jack detection quirk for Dell Venue 5585 Pierre-Louis Bossart
2017-08-23 11:24   ` Applied "ASoC: codecs: rt5670: add jack detection quirk for Dell Venue 5585" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 13/14] ASoC: Intel: cht_bsw_rt5672: use actual HID in suspend/resume Pierre-Louis Bossart
2017-09-25 16:16   ` Applied "ASoC: Intel: cht_bsw_rt5672: use actual HID in suspend/resume" to the asoc tree Mark Brown
2017-08-22 20:32 ` [PATCH 14/14] ASoC: Intel: cht_bsw_rt5672: fix card name Pierre-Louis Bossart
2017-09-25 16:16   ` Applied "ASoC: Intel: cht_bsw_rt5672: fix card name" to the asoc tree Mark Brown
2017-08-28 11:38 ` [PATCH 00/14] BYT/CHT codec/machine drivers update Pierre-Louis Bossart
2017-08-29 18:34   ` Mark Brown
2017-08-29 18:51     ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170822203239.19891-12-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.