From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Eryu Guan <eguan@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: skip free eofblocks if inode is under written back
Date: Wed, 30 Aug 2017 00:51:09 -0700 [thread overview]
Message-ID: <20170830075109.GA4711@infradead.org> (raw)
In-Reply-To: <20170830072950.GJ10621@dastard>
On Wed, Aug 30, 2017 at 05:29:50PM +1000, Dave Chinner wrote:
> Quick patch below, doesn't work on reflink filesystems yet because
> the way it handles cached COW mapping invalidation is unnecessarily
> special and so doesn't work. Can you test it and see if it fixes the
> problem?
FYI, I thought about this problem a while ago in the context of
rcu lookups of the extent tree (not, I'm not doing those quite yet,
but I though of the possibilities once we've got a btree!) and
then my answer was that we'd really need a seqlock around uses of
the imaps. I didn't think far enough that we might need something
like that even now..
next prev parent reply other threads:[~2017-08-30 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 4:26 [PATCH] xfs: skip free eofblocks if inode is under written back Eryu Guan
2017-08-30 7:29 ` Dave Chinner
2017-08-30 7:51 ` Christoph Hellwig [this message]
2017-08-30 8:10 ` Dave Chinner
2017-08-30 9:12 ` Eryu Guan
2017-08-30 14:26 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830075109.GA4711@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.