Re: [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb

From: "Daniel P. Berrange" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb
Date: Wed, 30 Aug 2017 17:01:26 +0100	[thread overview]
Message-ID: <20170830160126.GB31465@redhat.com> (raw)
In-Reply-To: <1503323345.26016.23.camel@redhat.com>

On Mon, Aug 21, 2017 at 03:49:05PM +0200, Gerd Hoffmann wrote:
> On Thu, 2017-08-10 at 16:55 +0100, Daniel P. Berrange wrote:
> > -    virtio_input_key_config(vinput, keymap_qcode,
> > -                            ARRAY_SIZE(keymap_qcode));
> > +    virtio_input_key_config(vinput, qemu_input_map_qcode2linux,
> > +                            qemu_input_map_qcode2linux_len);
> 
> That is a guest-visible change.

Huh, really ?!?!?

Are you saying the guest OS sees the raw qcode values ? IIUC these are
something we never wanted to expose outside QEMU, because nothing in
QAPI is gauranteeing enum values are stable - only the string
representation is stable in QAPI.

I thought this device was sending linux keycodes to the guest, not
qcodes ????

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|