From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: jun.nakajima@intel.com, kevin.tian@intel.com,
sstabellini@kernel.org, wei.liu2@citrix.com,
suravee.suthikulpanit@amd.com, george.dunlap@eu.citrix.com,
andrew.cooper3@citrix.com, tim@xen.org, xen-devel@lists.xen.org,
paul.durrant@citrix.com, jbeulich@suse.com,
Alexandru Isaila <aisaila@bitdefender.com>,
boris.ostrovsky@oracle.com, ian.jackson@eu.citrix.com
Subject: Re: [PATCH v2 2/4] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result
Date: Mon, 11 Sep 2017 14:32:11 +0100 [thread overview]
Message-ID: <20170911133211.a6acul3ay3yd2w2w@citrix.com> (raw)
In-Reply-To: <b375e793-72fd-e612-3732-c4a4ece3553b@citrix.com>
On Mon, Sep 11, 2017 at 02:27:34PM +0100, George Dunlap wrote:
> On 09/08/2017 05:05 PM, Alexandru Isaila wrote:
> > diff --git a/xen/include/asm-x86/hvm/support.h b/xen/include/asm-x86/hvm/support.h
> > index b18dbb6..e3b035d 100644
> > --- a/xen/include/asm-x86/hvm/support.h
> > +++ b/xen/include/asm-x86/hvm/support.h
> > @@ -53,23 +53,23 @@ extern unsigned int opt_hvm_debug_level;
> >
> > extern unsigned long hvm_io_bitmap[];
> >
> > -enum hvm_copy_result {
> > - HVMCOPY_okay = 0,
> > - HVMCOPY_bad_gva_to_gfn,
> > - HVMCOPY_bad_gfn_to_mfn,
> > - HVMCOPY_unhandleable,
> > - HVMCOPY_gfn_paged_out,
> > - HVMCOPY_gfn_shared,
> > +enum hvm_translation_result {
> > + HVMTRANS_okay,
> > + HVMTRANS_bad_linear_to_gfn,
> > + HVMTRANS_bad_gfn_to_mfn,
> > + HVMTRANS_unhandleable,
> > + HVMTRANS_gfn_paged_out,
> > + HVMTRANS_gfn_shared,
>
> Somehow "translation result" doesn't seem like the right name for this.
> gfn_to_mfn is a translation result; linear_to_gfn includes access checks.
>
> I'll admit though that by the end of the series, "Copy result" is *also*
> not the right name for it, and I can't think of a better name at the moment.
>
hvm_access_result?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-11 13:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 16:05 [PATCH v2 0/4] Various XSA followups Alexandru Isaila
2017-09-08 16:05 ` [PATCH v2 1/4] x86/shadow: Use ERR_PTR infrastructure for sh_emulate_map_dest() Alexandru Isaila
2017-09-12 9:37 ` Wei Liu
2017-09-08 16:05 ` [PATCH v2 2/4] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result Alexandru Isaila
2017-09-11 13:27 ` George Dunlap
2017-09-11 13:32 ` Wei Liu [this message]
2017-09-11 13:39 ` Andrew Cooper
2017-09-12 10:00 ` George Dunlap
2017-09-18 8:22 ` Tian, Kevin
2017-09-18 13:00 ` Jan Beulich
2017-09-08 16:05 ` [PATCH v2 3/4] x86/hvm: Break out __hvm_copy()'s translation logic Alexandru Isaila
2017-09-18 13:18 ` Jan Beulich
2017-09-08 16:05 ` [PATCH v2 4/4] x86/hvm: Implement hvmemul_write() using real mappings Alexandru Isaila
2017-09-12 14:32 ` Paul Durrant
2017-09-12 14:37 ` Andrew Cooper
2017-09-12 15:05 ` Jan Beulich
2017-09-12 15:06 ` Paul Durrant
2017-09-12 15:09 ` Andrew Cooper
2017-09-12 15:12 ` Paul Durrant
2017-09-18 13:43 ` Jan Beulich
2017-09-18 14:16 ` Alexandru Stefan ISAILA
2017-09-08 20:03 ` [PATCH v2 0/4] Various XSA followups Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911133211.a6acul3ay3yd2w2w@citrix.com \
--to=wei.liu2@citrix.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=paul.durrant@citrix.com \
--cc=sstabellini@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.