Re: [PATCH v3 8/8] iio: accel: kxcjk1013: drop variation number from driver's name

From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v3 8/8] iio: accel: kxcjk1013: drop variation number from driver's name
Date: Sat, 30 Sep 2017 00:05:54 +0200	[thread overview]
Message-ID: <20170929220554.pa5wzel6uhlukkqt@qmqm.qmqm.pl> (raw)
In-Reply-To: <1506707107.3098.3.camel@linux.intel.com>

On Fri, Sep 29, 2017 at 10:45:07AM -0700, Srinivas Pandruvada wrote:
> On Sun, 2017-09-24 at 16:03 +0100, Jonathan Cameron wrote:
> > On Sun, 17 Sep 2017 17:01:05 +0200
> > Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
> > 
> > > Rename kxcjk-1013 driver by removing -1013 suffix. '1013' is a
> > > variation
> > > specifier only (eg. different voltage) as can be seen in datasheet
> > > for eg. KXTF9 parts.
> > > 
> > > Old name is left as an modules's alias. Should not matter, though,
> > > for distros using proper module loading based on device name not
> > > module name.
> > > 
> > > Mostly a mechanical change + whitespace fixes.
> > > 
> > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > Whilst this seems logical I worry we'll break some random platforms
> > init scripts.   I think I'd rather not risk breakage and leave it as
> > it is.  Once we make a mistake like this, sometimes we are stuck
> > with it long term unfortunately.
> Agree. The config files are not touched when user upgrade kernel. So
> this may be simply overlooked. That is why we have compatible ids in
> both ACPI and DTs.

Ok, I see the point. I'll remove the renaming of kconfig symbol in
the next version.

Best Regards,
Michał Mirosław