From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Martin Kepplinger <martink@posteo.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
Harinath Nampally <harinath922@gmail.com>, <knaack.h@gmx.de>,
<lars@metafoo.de>, <pmeerw@pmeerw.net>,
<gregkh@linuxfoundation.org>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <amsfield22@gmail.com>
Subject: Re: [PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.
Date: Mon, 2 Oct 2017 11:35:10 +0100 [thread overview]
Message-ID: <20171002113510.00002392@huawei.com> (raw)
In-Reply-To: <3dac943e-5c50-363c-2e5b-77b2921e9e91@posteo.de>
On Sun, 1 Oct 2017 20:10:49 +0200
Martin Kepplinger <martink@posteo.de> wrote:
> On 2017-09-30 19:59, Jonathan Cameron wrote:
> > On Wed, 27 Sep 2017 08:52:54 +0200
> > Martin Kepplinger <martink@posteo.de> wrote:
> >
> >> Am 25.09.2017 12:40 schrieb Harinath Nampally:
> >>> Improves code readability, no impact on functionality.
> >>>
> >>> Signed-off-by: Harinath Nampally <harinath922@gmail.com>
> >>> ---
> >>
> >> I'd prefer a shorter subject line here too, see patch 2/3
> >
> > Agreed. I'm unconvinced the change helps. Perhaps that is
> > because I don't fully understand why you are making the change?
> >
>
> It's understandable for me. It simply uses "transient" and "ff_mt" in
> order to describe sets of device-registers instead of "rising" and
> "falling". That's more appropriate. I'd apply this if possible.
>
> Even though it should be clear after reading the data sheet, this
> particular issue sometimes gets confusing for people. Maybe a short
> descriptive comment, pointing to the data sheet, would make sense?
>
With the addition of some description, this should be fine.
Thanks,
Jonathan
> martin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-02 10:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 10:40 [PATCH v3 0/3] Refactor event related code Harinath Nampally
2017-09-25 10:40 ` [PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names Harinath Nampally
2017-09-27 6:52 ` Martin Kepplinger
2017-09-30 17:59 ` Jonathan Cameron
2017-10-01 18:10 ` Martin Kepplinger
2017-10-02 10:35 ` Jonathan Cameron [this message]
2017-10-03 2:57 ` harinath Nampally
2017-09-25 10:40 ` [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events Harinath Nampally
2017-09-27 6:51 ` Martin Kepplinger
2017-09-30 18:05 ` Jonathan Cameron
2017-09-30 18:18 ` harinath Nampally
2017-09-30 18:20 ` harinath Nampally
2017-09-25 10:40 ` [PATCH v3 3/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name Harinath Nampally
2017-09-27 6:46 ` Martin Kepplinger
2017-09-30 18:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002113510.00002392@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=amsfield22@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=harinath922@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.