From: Sakari Ailus <sakari.ailus@iki.fi>
To: Yong Zhi <yong.zhi@intel.com>
Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
hans.verkuil@cisco.com, jian.xu.zheng@intel.com,
tfiga@chromium.org, rajmohan.mani@intel.com,
tuukka.toivonen@intel.com, hyungwoo.yang@intel.com,
ramya.vijaykumar@intel.com, chiranjeevi.rapolu@intel.com
Subject: Re: [PATCH v5 2/3] doc-rst: add IPU3 raw10 bayer pixel format definitions
Date: Tue, 10 Oct 2017 11:32:40 +0300 [thread overview]
Message-ID: <20171010083239.7qjdkyee42fbileg@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1507333141-28242-3-git-send-email-yong.zhi@intel.com>
Hi Yong,
On Fri, Oct 06, 2017 at 06:39:00PM -0500, Yong Zhi wrote:
> The formats added by this patch are:
>
> V4L2_PIX_FMT_IPU3_SBGGR10
> V4L2_PIX_FMT_IPU3_SGBRG10
> V4L2_PIX_FMT_IPU3_SGRBG10
> V4L2_PIX_FMT_IPU3_SRGGB10
>
> Signed-off-by: Yong Zhi <yong.zhi@intel.com>
> Signed-off-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
> ---
> Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 +
> .../media/uapi/v4l/pixfmt-srggb10-ipu3.rst | 166 +++++++++++++++++++++
> 2 files changed, 167 insertions(+)
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst
>
> diff --git a/Documentation/media/uapi/v4l/pixfmt-rgb.rst b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> index 4cc27195dc79..cf2ef7df9616 100644
> --- a/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> +++ b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> @@ -16,6 +16,7 @@ RGB Formats
> pixfmt-srggb10p
> pixfmt-srggb10alaw8
> pixfmt-srggb10dpcm8
> + pixfmt-srggb10-ipu3
> pixfmt-srggb12
> pixfmt-srggb12p
> pixfmt-srggb16
> diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst b/Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst
> new file mode 100644
> index 000000000000..50292186a8b4
> --- /dev/null
> +++ b/Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst
> @@ -0,0 +1,166 @@
> +.. -*- coding: utf-8; mode: rst -*-
> +
> +.. _V4L2_PIX_FMT_IPU3_SBGGR10:
> +.. _V4L2_PIX_FMT_IPU3_SGBRG10:
> +.. _V4L2_PIX_FMT_IPU3_SGRBG10:
> +.. _V4L2_PIX_FMT_IPU3_SRGGB10:
> +
> +**********************************************************************************************************************************************
> +V4L2_PIX_FMT_IPU3_SBGGR10 ('ip3b'), V4L2_PIX_FMT_IPU3_SGBRG10 ('ip3g'), V4L2_PIX_FMT_IPU3_SGRBG10 ('ip3G'), V4L2_PIX_FMT_IPU3_SRGGB10 ('ip3r')
> +**********************************************************************************************************************************************
> +
> +10-bit Bayer formats
> +
> +Description
> +===========
> +
> +These four pixel formats are used by Intel IPU3 driver, they are raw
> +sRGB / Bayer formats with 10 bits per sample with every 25 pixels packed
> +to 32 bytes leaving 6 most significant bits padding in the last byte.
> +The format is little endian.
> +
> +In other respects this format is similar to :ref:`V4L2-PIX-FMT-SRGGB10`.
You could add:
Below is an example of a small image in V4L2_PIX_FMT_IPU3_SBGGR10 format.
> +
> +**Byte Order.**
> +Each cell is one byte.
> +
> +.. raw:: latex
> +
> + \newline\newline\begin{adjustbox}{width=\columnwidth}
> +
> +.. tabularcolumns:: |p{1.3cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|
The width of this table is over one metre. Could you use fewer columns in
it, say, four or eight?
> +
> +.. flat-table::
> +
> + * - start + 0:
> + - B\ :sub:`0000low`
> + - G\ :sub:`0001low` \ (bits 7--2) B\ :sub:`0000high`\ (bits 1--0)
> + - B\ :sub:`0002low` \ (bits 7--4) G\ :sub:`0001high`\ (bits 3--0)
> + - G\ :sub:`0003low` \ (bits 7--6) B\ :sub:`0002high`\ (bits 5--0)
> + - G\ :sub:`0003high`
> + - B\ :sub:`0004low`
> + - G\ :sub:`0005low` \ (bits 7--2) B\ :sub:`0004high`\ (bits 1--0)
> + - B\ :sub:`0006low` \ (bits 7--4) G\ :sub:`0005high`\ (bits 3--0)
> + - G\ :sub:`0007low` \ (bits 7--6) B\ :sub:`0006high`\ (bits 5--0)
> + - G\ :sub:`0007high`
> + - B\ :sub:`0008low`
> + - G\ :sub:`0009low` \ (bits 7--2) B\ :sub:`0008high`\ (bits 1--0)
> + - B\ :sub:`0010low` \ (bits 7--4) G\ :sub:`0009high`\ (bits 3--0)
> + - G\ :sub:`0011low` \ (bits 7--6) B\ :sub:`0010high`\ (bits 5--0)
> + - G\ :sub:`0011high`
> + - B\ :sub:`0012low`
> + - G\ :sub:`0013low` \ (bits 7--2) B\ :sub:`0012high`\ (bits 1--0)
> + - B\ :sub:`0014low` \ (bits 7--4) G\ :sub:`0013high`\ (bits 3--0)
> + - G\ :sub:`0015low` \ (bits 7--6) B\ :sub:`0014high`\ (bits 5--0)
> + - G\ :sub:`0015high`
> + - B\ :sub:`0016low`
> + - G\ :sub:`0017low` \ (bits 7--2) B\ :sub:`0016high`\ (bits 1--0)
> + - B\ :sub:`0018low` \ (bits 7--4) G\ :sub:`0017high`\ (bits 3--0)
> + - G\ :sub:`0019low` \ (bits 7--6) B\ :sub:`0018high`\ (bits 5--0)
> + - G\ :sub:`0019high`
> + - B\ :sub:`0020low`
> + - G\ :sub:`0021low` \ (bits 7--2) B\ :sub:`0020high`\ (bits 1--0)
> + - B\ :sub:`0022low` \ (bits 7--4) G\ :sub:`0021high`\ (bits 3--0)
> + - G\ :sub:`0023low` \ (bits 7--6) B\ :sub:`0022high`\ (bits 5--0)
> + - G\ :sub:`0023high`
> + - B\ :sub:`0024low`
> + - B\ :sub:`0024high`\ (bits 1--0)
> + * - start + 32:
> + - G\ :sub:`0100low`
> + - R\ :sub:`0101low` \ (bits 7--2) G\ :sub:`0100high`\ (bits 1--0)
> + - G\ :sub:`0102low` \ (bits 7--4) R\ :sub:`0101high`\ (bits 3--0)
> + - R\ :sub:`0103low` \ (bits 7--6) G\ :sub:`0102high`\ (bits 5--0)
> + - R\ :sub:`0103high`
> + - G\ :sub:`0104low`
> + - R\ :sub:`0105low` \ (bits 7--2) G\ :sub:`0104high`\ (bits 1--0)
> + - G\ :sub:`0106low` \ (bits 7--4) R\ :sub:`0105high`\ (bits 3--0)
> + - R\ :sub:`0107low` \ (bits 7--6) G\ :sub:`0106high`\ (bits 5--0)
> + - R\ :sub:`0107high`
> + - G\ :sub:`0108low`
> + - R\ :sub:`0109low` \ (bits 7--2) G\ :sub:`0108high`\ (bits 1--0)
> + - G\ :sub:`0110low` \ (bits 7--4) R\ :sub:`0109high`\ (bits 3--0)
> + - R\ :sub:`0111low` \ (bits 7--6) G\ :sub:`0110high`\ (bits 5--0)
> + - R\ :sub:`0111high`
> + - G\ :sub:`0112low`
> + - R\ :sub:`0113low` \ (bits 7--2) G\ :sub:`0112high`\ (bits 1--0)
> + - G\ :sub:`0114low` \ (bits 7--4) R\ :sub:`0113high`\ (bits 3--0)
> + - R\ :sub:`0115low` \ (bits 7--6) G\ :sub:`0114high`\ (bits 5--0)
> + - R\ :sub:`0115high`
> + - G\ :sub:`0116low`
> + - R\ :sub:`0117low` \ (bits 7--2) G\ :sub:`0116high`\ (bits 1--0)
> + - G\ :sub:`0118low` \ (bits 7--4) R\ :sub:`0117high`\ (bits 3--0)
> + - R\ :sub:`0119low` \ (bits 7--6) G\ :sub:`0118high`\ (bits 5--0)
> + - R\ :sub:`0119high`
> + - G\ :sub:`0120low`
> + - R\ :sub:`0121low` \ (bits 7--2) G\ :sub:`0120high`\ (bits 1--0)
> + - G\ :sub:`0122low` \ (bits 7--4) R\ :sub:`0121high`\ (bits 3--0)
> + - R\ :sub:`0123low` \ (bits 7--6) G\ :sub:`0122high`\ (bits 5--0)
> + - R\ :sub:`0123high`
> + - G\ :sub:`0124low`
> + - G\ :sub:`0124high`\ (bits 1--0)
> + * - start + 64:
> + - B\ :sub:`0200low`
> + - G\ :sub:`0201low` \ (bits 7--2) B\ :sub:`0200high`\ (bits 1--0)
> + - B\ :sub:`0202low` \ (bits 7--4) G\ :sub:`0201high`\ (bits 3--0)
> + - G\ :sub:`0203low` \ (bits 7--6) B\ :sub:`0202high`\ (bits 5--0)
> + - G\ :sub:`0203high`
> + - B\ :sub:`0204low`
> + - G\ :sub:`0205low` \ (bits 7--2) B\ :sub:`0204high`\ (bits 1--0)
> + - B\ :sub:`0206low` \ (bits 7--4) G\ :sub:`0205high`\ (bits 3--0)
> + - G\ :sub:`0207low` \ (bits 7--6) B\ :sub:`0206high`\ (bits 5--0)
> + - G\ :sub:`0207high`
> + - B\ :sub:`0208low`
> + - G\ :sub:`0209low` \ (bits 7--2) B\ :sub:`0208high`\ (bits 1--0)
> + - B\ :sub:`0210low` \ (bits 7--4) G\ :sub:`0209high`\ (bits 3--0)
> + - G\ :sub:`0211low` \ (bits 7--6) B\ :sub:`0210high`\ (bits 5--0)
> + - G\ :sub:`0211high`
> + - B\ :sub:`0212low`
> + - G\ :sub:`0213low` \ (bits 7--2) B\ :sub:`0212high`\ (bits 1--0)
> + - B\ :sub:`0214low` \ (bits 7--4) G\ :sub:`0213high`\ (bits 3--0)
> + - G\ :sub:`0215low` \ (bits 7--6) B\ :sub:`0214high`\ (bits 5--0)
> + - G\ :sub:`0215high`
> + - B\ :sub:`0216low`
> + - G\ :sub:`0217low` \ (bits 7--2) B\ :sub:`0216high`\ (bits 1--0)
> + - B\ :sub:`0218low` \ (bits 7--4) G\ :sub:`0217high`\ (bits 3--0)
> + - G\ :sub:`0219low` \ (bits 7--6) B\ :sub:`0218high`\ (bits 5--0)
> + - G\ :sub:`0219high`
> + - B\ :sub:`0220low`
> + - G\ :sub:`0221low` \ (bits 7--2) B\ :sub:`0220high`\ (bits 1--0)
> + - B\ :sub:`0222low` \ (bits 7--4) G\ :sub:`0221high`\ (bits 3--0)
> + - G\ :sub:`0223low` \ (bits 7--6) B\ :sub:`0222high`\ (bits 5--0)
> + - G\ :sub:`0223high`
> + - B\ :sub:`0224low`
> + - B\ :sub:`0224high`\ (bits 1--0)
> + * - start + 96:
> + - G\ :sub:`0300low`
> + - R\ :sub:`0301low` \ (bits 7--2) G\ :sub:`0300high`\ (bits 1--0)
> + - G\ :sub:`0302low` \ (bits 7--4) R\ :sub:`0301high`\ (bits 3--0)
> + - R\ :sub:`0303low` \ (bits 7--6) G\ :sub:`0302high`\ (bits 5--0)
> + - R\ :sub:`0303high`
> + - G\ :sub:`0304low`
> + - R\ :sub:`0305low` \ (bits 7--2) G\ :sub:`0304high`\ (bits 1--0)
> + - G\ :sub:`0306low` \ (bits 7--4) R\ :sub:`0305high`\ (bits 3--0)
> + - R\ :sub:`0307low` \ (bits 7--6) G\ :sub:`0306high`\ (bits 5--0)
> + - R\ :sub:`0307high`
> + - G\ :sub:`0308low`
> + - R\ :sub:`0309low` \ (bits 7--2) G\ :sub:`0308high`\ (bits 1--0)
> + - G\ :sub:`0310low` \ (bits 7--4) R\ :sub:`0309high`\ (bits 3--0)
> + - R\ :sub:`0311low` \ (bits 7--6) G\ :sub:`0310high`\ (bits 5--0)
> + - R\ :sub:`0311high`
> + - G\ :sub:`0312low`
> + - R\ :sub:`0313low` \ (bits 7--2) G\ :sub:`0312high`\ (bits 1--0)
> + - G\ :sub:`0314low` \ (bits 7--4) R\ :sub:`0313high`\ (bits 3--0)
> + - R\ :sub:`0315low` \ (bits 7--6) G\ :sub:`0314high`\ (bits 5--0)
> + - R\ :sub:`0315high`
> + - G\ :sub:`0316low`
> + - R\ :sub:`0317low` \ (bits 7--2) G\ :sub:`0316high`\ (bits 1--0)
> + - G\ :sub:`0318low` \ (bits 7--4) R\ :sub:`0317high`\ (bits 3--0)
> + - R\ :sub:`0319low` \ (bits 7--6) G\ :sub:`0318high`\ (bits 5--0)
> + - R\ :sub:`0319high`
> + - G\ :sub:`0320low`
> + - R\ :sub:`0321low` \ (bits 7--2) G\ :sub:`0320high`\ (bits 1--0)
> + - G\ :sub:`0322low` \ (bits 7--4) R\ :sub:`0321high`\ (bits 3--0)
> + - R\ :sub:`0323low` \ (bits 7--6) G\ :sub:`0322high`\ (bits 5--0)
> + - R\ :sub:`0323high`
> + - G\ :sub:`0324low`
> + - G\ :sub:`0324high`\ (bits 1--0)
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi
next prev parent reply other threads:[~2017-10-10 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 23:38 [PATCH v5 0/3] [media] add IPU3 CIO2 CSI2 driver Yong Zhi
2017-10-06 23:38 ` [PATCH v5 1/3] videodev2.h, v4l2-ioctl: add IPU3 raw10 color format Yong Zhi
2017-10-06 23:39 ` [PATCH v5 2/3] doc-rst: add IPU3 raw10 bayer pixel format definitions Yong Zhi
2017-10-10 8:32 ` Sakari Ailus [this message]
2017-10-24 23:14 ` Zhi, Yong
2017-10-06 23:39 ` [PATCH v5 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver Yong Zhi
2017-10-10 7:45 ` Sakari Ailus
2017-10-12 1:02 ` Zhi, Yong
2017-10-12 6:19 ` Sakari Ailus
2017-10-17 22:55 ` Zhi, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010083239.7qjdkyee42fbileg@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=chiranjeevi.rapolu@intel.com \
--cc=hans.verkuil@cisco.com \
--cc=hyungwoo.yang@intel.com \
--cc=jian.xu.zheng@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=ramya.vijaykumar@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=tuukka.toivonen@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.