From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, "Wei Liu" <wei.liu2@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 1/2] libxl: dm_restrict: Move to domain_build_info
Date: Thu, 12 Oct 2017 12:23:35 +0100 [thread overview]
Message-ID: <20171012112335.re4bctc32eccbwyn@citrix.com> (raw)
In-Reply-To: <1507807267-13709-1-git-send-email-ian.jackson@eu.citrix.com>
On Thu, Oct 12, 2017 at 12:21:06PM +0100, Ian Jackson wrote:
> Right now, this is broken because libxl__build_device_model_args_new
> is used also for the qemu run for pv guests for qdisk devices, pvfb,
> etc.
>
> We can either make this option properly HVM-specific, or make it
> generic.
>
> In principle it is a reasonable request, to make the PV qemu
> deprivileged (even though it is not likely to be implemented any time
> soon). So make this option generic.
>
> We retain the name "device model" even though it is arguably
> inaccurate, because the xl docs already say, for example
> For a PV guest a device-model is sometimes used to provide backends
> for certain PV devices
>
> The documentation patch here is pure code motion. For ease of review
> we will fix up the docs, so the wording to be right for the new
> context, in the next patch.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Reported-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-12 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 11:21 [PATCH 1/2] libxl: dm_restrict: Move to domain_build_info Ian Jackson
2017-10-12 11:21 ` [PATCH 2/2] xl: dm_restrict: Document that it does not work with PV Ian Jackson
2017-10-12 11:23 ` Wei Liu
2017-10-12 11:45 ` Roger Pau Monné
2017-10-12 11:23 ` Wei Liu [this message]
2017-10-12 11:44 ` [PATCH 1/2] libxl: dm_restrict: Move to domain_build_info Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012112335.re4bctc32eccbwyn@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.